Skip to content

Conversation

pan-pawel
Copy link
Contributor

@pan-pawel pan-pawel commented May 20, 2020

accessiblityStates is removed in 0.62 and that causing typescript errors. With this PR I'm changing paper to use new accessibilityState also we want to update @types/react-native because accessibilityState wasn't exist in 0.57.61|
Issue: #1920
Unfortunately it's a breaking change for people using older version of react-native and we want to add it to 4.0

@github-actions
Copy link

The mobile version of example app from this branch is ready! You can see it here

.

@pan-pawel pan-pawel changed the base branch from master to 4.0 May 21, 2020 09:16
@callstack-bot
Copy link

callstack-bot commented May 21, 2020

Hey @pan-pawel, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@pan-pawel pan-pawel force-pushed the feat/change-deprecated-accessibilityStates branch 2 times, most recently from 46ce34d to c2056c1 Compare May 21, 2020 09:45
@pan-pawel pan-pawel marked this pull request as ready for review May 21, 2020 09:46
@pan-pawel pan-pawel requested a review from Trancever May 21, 2020 09:50
@pan-pawel pan-pawel changed the title [WIP] change deprecated accessiblityStates to accessibilityState [4.0] change deprecated accessiblityStates to accessibilityState May 21, 2020
@pan-pawel pan-pawel requested review from jbinda and matkoson May 21, 2020 10:30
Copy link
Contributor

@matkoson matkoson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trancever Overlaps with #1937

Copy link
Collaborator

@wojteg1337 wojteg1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wojteg1337
Copy link
Collaborator

@pan-pawel
resolve conflicts so we can merge this guy

@pan-pawel pan-pawel force-pushed the feat/change-deprecated-accessibilityStates branch from c2056c1 to 46ce34d Compare May 25, 2020 11:00
@pan-pawel pan-pawel force-pushed the feat/change-deprecated-accessibilityStates branch from 46ce34d to 5d19b74 Compare May 25, 2020 11:09
@pan-pawel pan-pawel merged commit 87fcb50 into 4.0 May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants