Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore: change macos-14 to macos-latest
macos-latest now uses M1 macs. so we don't need to specify macos-14 anymore
  • Loading branch information
satya164 committed Dec 17, 2024
commit d28cbdbe492eb85d44b8a645509b45141436dba4
12 changes: 6 additions & 6 deletions .github/workflows/build-templates.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ jobs:
fail-fast: false
matrix:
os:
- ubuntu-latest
- macos-14 # macos latest defaults to macos 12 at the moment.
- ubuntu
- macos
type:
- turbo-module
- fabric-view
Expand All @@ -48,15 +48,15 @@ jobs:
- type: legacy-view
language: cpp
include:
- os: ubuntu-latest
- os: ubuntu
type: library
language: js

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ matrix.os }}-${{ matrix.type }}-${{ matrix.language }}
cancel-in-progress: true

runs-on: ${{ matrix.os }}
runs-on: ${{ matrix.os }}-latest

steps:
- name: Checkout
Expand Down Expand Up @@ -129,14 +129,14 @@ jobs:
working-directory: ${{ env.work_dir }}
run: |
# Build Android for only some matrices to skip redundant builds
if [[ ${{ matrix.os }} == ubuntu-latest ]]; then
if [[ ${{ matrix.os }} == ubuntu ]]; then
if [[ ${{ matrix.type }} == *-view && ${{ matrix.language }} == *-objc ]] || [[ ${{ matrix.type }} == *-module && ${{ matrix.language }} == *-objc ]] || [[ ${{ matrix.type }} == *-module && ${{ matrix.language }} == cpp ]]; then
echo "android_build=1" >> $GITHUB_ENV
fi
fi

# Build iOS for only some matrices to skip redundant builds
if [[ ${{ matrix.os }} == macos-14 ]]; then
if [[ ${{ matrix.os }} == macos ]]; then
if [[ ${{ matrix.type }} == *-view && ${{ matrix.language }} == kotlin-* ]] || [[ ${{ matrix.type }} == *-module && ${{ matrix.language }} == kotlin-* ]] || [[ ${{ matrix.type }} == *-module && ${{ matrix.language }} == cpp ]]; then
echo "ios_build=1" >> $GITHUB_ENV
fi
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ jobs:
yarn turbo run build:android --cache-dir="${{ env.TURBO_CACHE_DIR }}"

build-ios:
runs-on: macos-14
runs-on: macos-latest
env:
TURBO_CACHE_DIR: .turbo/ios
steps:
Expand Down
Loading