Skip to content

Commit ba0d0aa

Browse files
committed
use parameter constants for extensions maps in token service
1 parent ac0cafe commit ba0d0aa

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

openid-connect-server/src/main/java/org/mitre/openid/connect/service/impl/DefaultOIDCTokenService.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@
1616
*******************************************************************************/
1717
package org.mitre.openid.connect.service.impl;
1818

19+
import static org.mitre.openid.connect.request.ConnectRequestParameters.MAX_AGE;
20+
import static org.mitre.openid.connect.request.ConnectRequestParameters.NONCE;
21+
1922
import java.util.Date;
2023
import java.util.Map;
2124
import java.util.Set;
@@ -58,7 +61,6 @@
5861
import com.nimbusds.jwt.JWTClaimsSet;
5962
import com.nimbusds.jwt.PlainJWT;
6063
import com.nimbusds.jwt.SignedJWT;
61-
6264
/**
6365
* Default implementation of service to create specialty OpenID Connect tokens.
6466
*
@@ -105,7 +107,7 @@ public OAuth2AccessTokenEntity createIdToken(ClientDetailsEntity client, OAuth2R
105107
JWTClaimsSet.Builder idClaims = new JWTClaimsSet.Builder();
106108

107109
// if the auth time claim was explicitly requested OR if the client always wants the auth time, put it in
108-
if (request.getExtensions().containsKey("max_age")
110+
if (request.getExtensions().containsKey(MAX_AGE)
109111
|| (request.getExtensions().containsKey("idtoken")) // TODO: parse the ID Token claims (#473) -- for now assume it could be in there
110112
|| (client.getRequireAuthTime() != null && client.getRequireAuthTime())) {
111113

@@ -134,7 +136,7 @@ public OAuth2AccessTokenEntity createIdToken(ClientDetailsEntity client, OAuth2R
134136
idClaims.audience(Lists.newArrayList(client.getClientId()));
135137
idClaims.jwtID(UUID.randomUUID().toString()); // set a random NONCE in the middle of it
136138

137-
String nonce = (String)request.getExtensions().get("nonce");
139+
String nonce = (String)request.getExtensions().get(NONCE);
138140
if (!Strings.isNullOrEmpty(nonce)) {
139141
idClaims.claim("nonce", nonce);
140142
}

0 commit comments

Comments
 (0)