Bug #25997748: MIGRATE FROM HASH TO STD::UNORDERED_MAP [patch 15]

Finally remove HASH, now that there are no more users left. Change-Id: I4c41878f331623d5ac5174750ca88b3917a26be0

Author: Steinar H. Gunderson

client/mysqldump.cc

@@ -44,7 +44,6 @@
 
 #include <errno.h>
 #include <fcntl.h>
-#include <hash.h>
 #include <m_ctype.h>
 #include <m_string.h>
 #include <my_sys.h>

client/mysqltest.cc

@@ -32,7 +32,6 @@
 #include <assert.h>
 #include <errno.h>
 #include <fcntl.h>
-#include <hash.h>
 #include <limits.h>
 #include <m_ctype.h>
 #include <mf_wcomp.h> // wild_compare

include/hash.h

@@ -27,7 +27,6 @@
 
 #include <atomic>
 
-#include "hash.h"
 #include "my_inttypes.h"
 #include "my_macros.h"
 #include "mysql/psi/mysql_statement.h"
@@ -166,6 +165,18 @@ typedef void lf_hash_init_func(uchar *dst, const uchar* src);
 /* lf_hash overhead per element (that is, sizeof(LF_SLIST) */
 extern const int LF_HASH_OVERHEAD;
 
+/**
+ Callback for extracting key and key length from user data in a LF_HASH.
+ @param arg Pointer to user data.
+ @param[out] length Store key length here.
+ @return Pointer to key to be hashed.
+
+ @note Was my_hash_get_key, with lots of C-style casting when calling
+ my_hash_init. Renamed to force build error (since signature changed)
+ in case someone keeps following that coding style.
+ */
+typedef const uchar *(*hash_get_key_function)(const uchar *arg, size_t *length);
+
 typedef struct st_lf_hash {
  LF_DYNARRAY array; /* hash itself */
  LF_ALLOCATOR alloc; /* allocator for elements */

include/lf.h

@@ -22,7 +22,6 @@ SET(MYSYS_SOURCES
  charset-def.cc
  checksum.cc
  errors.cc
- hash.cc
  lf_alloc-pin.cc
  lf_dynarray.cc
  lf_hash.cc