Skip to content

Commit da03d9b

Browse files
author
Ace Nassri
authored
functions/slack: config.json -> env vars (GoogleCloudPlatform#1751)
**Do not merge** until @labtopia updates the docs accordingly.
1 parent fab87f8 commit da03d9b

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

functions/slack/index.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
'use strict';
1616

1717
// [START functions_slack_setup]
18-
const config = require('./config.json');
1918
const {google} = require('googleapis');
2019
const {verifyRequestSignature} = require('@slack/events-api');
2120

@@ -94,7 +93,7 @@ const formatSlackMessage = (query, response) => {
9493
*/
9594
const verifyWebhook = (req) => {
9695
const signature = {
97-
signingSecret: config.SLACK_SECRET,
96+
signingSecret: process.env.SLACK_SECRET,
9897
requestSignature: req.headers['x-slack-signature'],
9998
requestTimestamp: req.headers['x-slack-request-timestamp'],
10099
body: req.rawBody,
@@ -118,7 +117,7 @@ const makeSearchRequest = (query) => {
118117
return new Promise((resolve, reject) => {
119118
kgsearch.entities.search(
120119
{
121-
auth: config.KG_API_KEY,
120+
auth: process.env.KG_API_KEY,
122121
query: query,
123122
limit: 1,
124123
},

functions/slack/test/index.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ const getSample = () => {
4343
return {
4444
program: proxyquire('../', {
4545
googleapis: {google: googleapis},
46-
'./config.json': config,
46+
process: { env: config },
4747
'@slack/events-api': eventsApi,
4848
}),
4949
mocks: {

0 commit comments

Comments
 (0)