Skip to content

Conversation

@grisumbras
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Merging #800 (4d22409) into develop (3404427) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@ ## develop #800 +/- ## ======================================== Coverage 99.00% 99.00% ======================================== Files 71 71 Lines 6824 6831 +7 ======================================== + Hits 6756 6763 +7  Misses 68 68 
Impacted Files Coverage Δ
include/boost/json/value.hpp 98.94% <ø> (ø)
include/boost/json/impl/parse.ipp 100.00% <100.00%> (ø)
include/boost/json/impl/value.ipp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3404427...4d22409. Read the comment docs.

@vinniefalco
Copy link
Member

should this return result<value>?

@grisumbras grisumbras force-pushed the refactor/istream-parse branch from 73173d1 to fa80c3d Compare November 6, 2022 09:18
@grisumbras grisumbras force-pushed the refactor/istream-parse branch from fa80c3d to 4d22409 Compare November 6, 2022 09:22
@grisumbras grisumbras marked this pull request as ready for review November 6, 2022 10:16
@grisumbras grisumbras merged commit 4d22409 into boostorg:develop Nov 6, 2022
@grisumbras grisumbras deleted the refactor/istream-parse branch November 6, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants