fixed the selection rotation state management issues

Author: geniusgeek

.gitignore

@@ -12,9 +12,9 @@
 bin/
 gen/
 
-# Local configuration file (sdk path, etc)
-local.properties
-gradle.properties
+# Local configuration file (sdk path, etc) just .properties will do
+*.properties
+ 
 
 # Windows thumbnail db
 Thumbs.db
@@ -28,7 +28,7 @@ Thumbs.db
 
 # Android Studio
 .idea
-.iml
+*.iml
 #.idea/workspace.xml - remove # and delete .idea if it better suit your needs.
 .gradle
 build/

criminalintent-sample/src/main/java/com/bignerdranch/android/criminalintent/BaseFragment.java

@@ -10,4 +10,6 @@ protected ActionBar getActionBar() {
  return ((ActionBarActivity) getActivity()).getSupportActionBar();
  }
 
+
+
 }

criminalintent-sample/src/main/java/com/bignerdranch/android/criminalintent/CrimeListFragment.java

@@ -28,15 +28,15 @@
 
 import java.util.ArrayList;
 
-public class CrimeListFragment extends BaseFragment {
-
+public class CrimeListFragment extends BaseFragment { 
  private RecyclerView mRecyclerView;
  private static final String TAG="crimeListFragment";
  private MultiSelector mMultiSelector = new MultiSelector();
-
- private ArrayList<Crime> mCrimes;
+ private ArrayList<Crime> mCrimes;
  private boolean mSubtitleVisible;
- 
+
+
+
  @Override
  public void onCreate(Bundle savedInstanceState) {
  super.onCreate(savedInstanceState);
@@ -46,12 +46,33 @@ public void onCreate(Bundle savedInstanceState) {
  mSubtitleVisible = false;
  }
 
+ /**
+ * Note: since the fragment is retained. the bundle passed in after state is restored is null.
+ * THe only way to pass parcelable objects is through the activities onsavedInstanceState and appropiate startup lifecycle
+ * However after having second thoughts, since the fragment is retained then all the states and instance variables are
+ * retained as well. no need to make the selection states percelable therefore just check for the selectionstate
+ * from the multiselector
+ */
+ @Override
+ public void onActivityCreated(Bundle savedInstanceState) {
+ super.onActivityCreated(savedInstanceState);
+ if(mMultiSelector.isSelectable()){
+ if(mDeleteMode !=null){
+ mDeleteMode.setClearOnPrepare(!mDeleteMode.shouldClearOnPrepare());
+ beginActionMode();
+
+
+ }
+
+ }
+ }
+
  @TargetApi(11)
  @Override
  public View onCreateView(LayoutInflater inflater, ViewGroup parent, Bundle savedInstanceState) {
  View v = inflater.inflate(R.layout.fragment_recyclerview, parent, false);
 
- if (mSubtitleVisible) {
+  if (mSubtitleVisible) {
  getActionBar().setSubtitle(R.string.subtitle);
  }
 
@@ -60,7 +81,6 @@ public View onCreateView(LayoutInflater inflater, ViewGroup parent, Bundle saved
  mCrimes = CrimeLab.get(getActivity()).getCrimes();
  mRecyclerView.setAdapter(new CrimeAdapter());
 
-
  return v;
  }
 
@@ -103,7 +123,7 @@ public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) {
  }
  }
 
- private ActionMode.Callback mDeleteMode = new ModalMultiSelectorCallback(mMultiSelector) {
+ private ModalMultiSelectorCallback mDeleteMode = new ModalMultiSelectorCallback(mMultiSelector) {
 
  @Override
  public boolean onCreateActionMode(ActionMode actionMode, Menu menu) {
@@ -179,8 +199,7 @@ public void onCreateContextMenu(ContextMenu menu, View v, ContextMenuInfo menuIn
  }
 
 
- private class CrimeHolder extends SwappingHolder
- implements View.OnClickListener, View.OnLongClickListener {
+ private class CrimeHolder extends SwappingHolder {
  private final TextView mTitleTextView;
  private final TextView mDateTextView;
  private final CheckBox mSolvedCheckBox;
@@ -193,8 +212,7 @@ public CrimeHolder(View itemView) {
  mDateTextView = (TextView) itemView.findViewById(R.id.crime_list_item_dateTextView);
  mSolvedCheckBox = (CheckBox) itemView.findViewById(R.id.crime_list_item_solvedCheckBox);
  itemView.setOnClickListener(this);
- itemView.setOnLongClickListener(this);
- itemView.setLongClickable(true);
+
  }
 
  public void bindCrime(Crime crime) {
@@ -206,21 +224,28 @@ public void bindCrime(Crime crime) {
 
  @Override
  public void onClick(View v) {
- if (mCrime == null) {
+ super.onClick(v);
+ if (mCrime == null || mMultiSelector.isSelectable()) {
  return;
  }
- if (!mMultiSelector.tapSelection(this)) {
-  selectCrime(mCrime);
- }
+
+ selectCrime(mCrime);
+
  }
 
  @Override
- public boolean onLongClick(View v) {
- ActionBarActivity activity = (ActionBarActivity)getActivity();
- activity.startSupportActionMode(mDeleteMode);
- mMultiSelector.setSelected(this, true);
- return true;
+ public void beginSelectionActionMode() {
+ beginActionMode();
+
  }
+
+
+ }
+
+ private void beginActionMode() {
+ ActionBarActivity activity = (ActionBarActivity)getActivity();
+ activity.startSupportActionMode(mDeleteMode);
+
  }
 
  private class CrimeAdapter extends RecyclerView.Adapter<CrimeHolder> {

recyclerview-multiselect/src/main/java/android/support/v7/widget/RebindReportingHolder.java

@@ -46,8 +46,13 @@ private void checkFlags(int setFlags) {
  }
  }
 
+ /**
+ * check if the view is due for rebiding
+ * @param flag
+ * @return
+ */
  private static boolean isRelevantFlagSet(int flag) {
- for (Integer value : new int[] { FLAG_BOUND, FLAG_CHANGED, FLAG_UPDATE, FLAG_RETURNED_FROM_SCRAP }) {
+ for (Integer value : new int[] { FLAG_BOUND, FLAG_CHANGED, FLAG_UPDATE, FLAG_RETURNED_FROM_SCRAP ,FLAG_TMP_DETACHED}) {
  if ((flag & value) == value) {
  return true;
  }

recyclerview-multiselect/src/main/java/com/bignerdranch/android/multiselector/ModalMultiSelectorCallback.java

@@ -11,8 +11,9 @@
  * and {@link android.support.v7.view.ActionMode.Callback#onDestroyActionMode(android.support.v7.view.ActionMode)}.</p>
  */
 public abstract class ModalMultiSelectorCallback implements ActionMode.Callback {
- private MultiSelector mMultiSelector;
 
+ private MultiSelector mMultiSelector;
+ private static final String TAG="modalMultiSelectorCallback";
  private boolean mClearOnPrepare = true;
 
  public ModalMultiSelectorCallback(MultiSelector multiSelector) {
@@ -66,4 +67,7 @@ public boolean onPrepareActionMode(ActionMode actionMode, Menu menu) {
  public void onDestroyActionMode(ActionMode actionMode) {
  mMultiSelector.setSelectable(false);
  }
+
+
+
 }

recyclerview-multiselect/src/main/java/com/bignerdranch/android/multiselector/MultiSelector.java

@@ -35,8 +35,7 @@
 public class MultiSelector {
  private SparseBooleanArray mSelections = new SparseBooleanArray();
  private WeakHolderTracker mTracker = new WeakHolderTracker();
-
- private boolean mIsSelectable;
+ private boolean mIsSelectable;
 
  /**
  * <p>Toggle whether this MultiSelector is in selection mode or not.
@@ -196,4 +195,6 @@ private void refreshHolder(SelectableHolder holder) {
  boolean isActivated = mSelections.get(holder.getPosition());
  holder.setActivated(isActivated);
  }
+
+
 }

recyclerview-multiselect/src/main/java/com/bignerdranch/android/multiselector/SwappingHolder.java

@@ -33,8 +33,8 @@
  *
  * <p>(Thanks to <a href="https://github.com/kurtisnelson/">Kurt Nelson</a> for examples and discussion on approaches here.)</p>
  */
-public class SwappingHolder extends MultiSelectorBindingHolder implements SelectableHolder {
- /**
+public abstract class SwappingHolder extends MultiSelectorBindingHolder implements SelectableHolder,View.OnClickListener, View.OnLongClickListener {
+  /**
  * <p>Construct a new SelectableHolder hooked up to be controlled by a MultiSelector.</p>
  *
  * <p>If the MultiSelector is not null, the SelectableHolder can be selected by
@@ -49,7 +49,8 @@ public class SwappingHolder extends MultiSelectorBindingHolder implements Select
  */
  public SwappingHolder(View itemView, MultiSelector multiSelector) {
  super(itemView, multiSelector);
-
+ this.itemView.setOnLongClickListener(this);
+ this.itemView.setLongClickable(true);
  mMultiSelector = multiSelector;
  if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
  setSelectionModeStateListAnimator(getRaiseStateListAnimator(itemView.getContext()));
@@ -284,4 +285,29 @@ private static StateListAnimator getRaiseStateListAnimator(Context context) {
  return null;
  }
  }
+
+ /**
+ * just few cleanup to handle click event
+ * Note: subclass should call super.onClick before implementation of their onClick
+ */
+ @Override
+ public void onClick(View v) {
+ if (!mMultiSelector.tapSelection(this)) {
+ return;
+ }
+ }
+
+ /**
+ *
+ *
+ * just few cleanup to handle starting up the selection mode
+ * Note: subclass should call super.onLongClick before implementation of their onLongClick
+ */
+ @Override
+ public boolean onLongClick(View v) {
+ beginSelectionActionMode();
+ mMultiSelector.setSelected(this, true);
+ return true;
+ }
+ public abstract void beginSelectionActionMode();
 }