Skip to content

Commit f4908a7

Browse files
author
Dmitry Rozhkov
authored
Merge pull request intel#343 from mythi/qatcoverage
dpdkdrv: improve unit test coverage
2 parents 336d2b3 + a6bf48f commit f4908a7

File tree

1 file changed

+47
-0
lines changed

1 file changed

+47
-0
lines changed

cmd/qat_plugin/dpdkdrv/dpdkdrv_test.go

Lines changed: 47 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,53 @@ func createTestFiles(prefix string, dirs []string, files map[string][]byte, syml
6363
return nil
6464
}
6565

66+
func TestNewDevicePlugin(t *testing.T) {
67+
68+
tcases := []struct {
69+
name string
70+
dpdkDriver string
71+
kernelVfDrivers string
72+
expectedErr bool
73+
}{
74+
{
75+
name: "Wrong dpdkDriver",
76+
dpdkDriver: "uio",
77+
kernelVfDrivers: "c6xxvf",
78+
expectedErr: true,
79+
},
80+
{
81+
name: "Correct dpdkDriver, wrong kernelVfDrivers",
82+
dpdkDriver: "vfio-pci",
83+
kernelVfDrivers: "c6xxxvf",
84+
expectedErr: true,
85+
},
86+
{
87+
name: "Correct dpdkDriver, kernelVfDrivers separated wrong",
88+
dpdkDriver: "vfio-pci",
89+
kernelVfDrivers: "c6xxvf:d15xxvf",
90+
expectedErr: true,
91+
},
92+
{
93+
name: "No errors",
94+
dpdkDriver: "vfio-pci",
95+
kernelVfDrivers: "c6xxvf,d15xxvf",
96+
expectedErr: false,
97+
},
98+
}
99+
for _, tt := range tcases {
100+
t.Run(tt.name, func(t *testing.T) {
101+
_, err := NewDevicePlugin(1, tt.kernelVfDrivers, tt.dpdkDriver)
102+
103+
if tt.expectedErr && err == nil {
104+
t.Errorf("Test case '%s': expected error", tt.name)
105+
}
106+
if !tt.expectedErr && err != nil {
107+
t.Errorf("Test case '%s': expected success", tt.name)
108+
}
109+
})
110+
}
111+
}
112+
66113
func TestScanPrivate(t *testing.T) {
67114
tmpdir := fmt.Sprintf("/tmp/qatplugin-TestScanPrivate-%d", time.Now().Unix())
68115
pciDrvDir := path.Join(tmpdir, "sys/bus/pci/drivers")

0 commit comments

Comments
 (0)