:else for conditions: remove condp (won't work) #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
`condp` can't usually take an :else label for its default since it's rare that the predicate would happen to evaluate to `true` for :else --- as demonstrated by the next example which uses condp with an unlabelled default.
bbatsov added a commit that referenced this pull request Mar 22, 2014
:else for conditions: remove condp (won't work)
Owner
| Indeed. Thanks for spotting this. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
condpcan't usually take an:elselabel for its default since it's rare that the predicate would happen to evaluate totruefor:else--- as demonstrated by the next example which usescondpwith an unlabelled default.