Skip to content
This repository was archived by the owner on Aug 18, 2021. It is now read-only.

Commit 4cf9ac1

Browse files
fsonhzoo
authored andcommitted
Remove the lodash.assign dependency (#393)
lodash.assign is deprecated: ``` npm WARN deprecated lodash.assign@4.2.0: This package is deprecated. Use Object.assign. ```
1 parent 9346a60 commit 4cf9ac1

File tree

3 files changed

+6
-9
lines changed

3 files changed

+6
-9
lines changed

index.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
var babylonToEspree = require("./babylon-to-espree");
2-
var assign = require("lodash.assign");
32
var pick = require("lodash.pickby");
43
var Module = require("module");
54
var path = require("path");
@@ -54,13 +53,13 @@ function monkeypatch() {
5453
// monkeypatch estraverse
5554
estraverse = estraverseRelative.require("estraverse");
5655
estraverses.push(estraverse);
57-
assign(estraverse.VisitorKeys, t.VISITOR_KEYS);
56+
Object.assign(estraverse.VisitorKeys, t.VISITOR_KEYS);
5857

5958
// monkeypatch estraverse-fb (only for eslint < 2.3.0)
6059
try {
6160
var estraverseFb = eslintMod.require("estraverse-fb");
6261
estraverses.push(estraverseFb);
63-
assign(estraverseFb.VisitorKeys, t.VISITOR_KEYS);
62+
Object.assign(estraverseFb.VisitorKeys, t.VISITOR_KEYS);
6463
} catch (err) {
6564
// Ignore: ESLint v2.3.0 does not have estraverse-fb
6665
}
@@ -69,7 +68,7 @@ function monkeypatch() {
6968
var estraverseOfEslint = eslintMod.require("estraverse");
7069
if (estraverseOfEslint !== estraverseFb) {
7170
estraverses.push(estraverseOfEslint);
72-
assign(estraverseOfEslint.VisitorKeys, t.VISITOR_KEYS);
71+
Object.assign(estraverseOfEslint.VisitorKeys, t.VISITOR_KEYS);
7372
}
7473

7574
estraverses.forEach(function (estraverse) {

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
"babel-traverse": "^6.0.20",
1616
"babel-types": "^6.0.19",
1717
"babylon": "^6.11.2",
18-
"lodash.assign": "^4.0.0",
1918
"lodash.pickby": "^4.0.0"
2019
},
2120
"scripts": {

test/integration.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
var assert = require("assert");
2-
var assign = require("lodash.assign");
32
var eslint = require("eslint");
43
var fs = require("fs");
54
var path = require("path");
@@ -56,7 +55,7 @@ function strictSuite () {
5655
var ruleId = "strict";
5756

5857
describe("when set to 'never'", function () {
59-
var eslintOpts = assign({}, baseEslintOpts, {
58+
var eslintOpts = Object.assign({}, baseEslintOpts, {
6059
rules: {},
6160
});
6261
eslintOpts.rules[ruleId] = [errorLevel, "never"];
@@ -81,7 +80,7 @@ function strictSuite () {
8180
// describe
8281

8382
describe("when set to 'global'", function () {
84-
var eslintOpts = assign({}, baseEslintOpts, {
83+
var eslintOpts = Object.assign({}, baseEslintOpts, {
8584
rules: {}
8685
});
8786
eslintOpts.rules[ruleId] = [errorLevel, "global"];
@@ -145,7 +144,7 @@ function strictSuite () {
145144
// describe
146145

147146
describe("when set to 'function'", function () {
148-
var eslintOpts = assign({}, baseEslintOpts, {
147+
var eslintOpts = Object.assign({}, baseEslintOpts, {
149148
rules: {}
150149
});
151150
eslintOpts.rules[ruleId] = [errorLevel, "function"];

0 commit comments

Comments
 (0)