fix: Branch key creation uses unchanged input #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Discovery and changing the region of a KMS key on decrypt do not mutate the customer input. This aligns with customer intent. Further the behavior of the code is to use the provided key directly #267 underspecified how branch keys should be created so this PR rolls back that change.
seebees force-pushed the seebees/branch-key-creation branch from c538a6c to 39901e2 Compare 
ajewellamz approved these changes May 7, 2025
texastony pushed a commit that referenced this pull request Jun 20, 2025
Discovery and changing the region of a KMS key on decrypt do not mutate the customer input. This aligns with customer intent. Further the behavior of the code is to use the provided key directly #267 underspecified how branch keys should be created so this PR rolls back that change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Discovery and changing the region of a KMS key
on decrypt do not mutate the customer input.
This aligns with customer intent.
Further the behavior of the code is to use the provided key directly
#267 underspecified how branch keys should be created so this PR rolls back that change.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Check any applicable: