Skip to content

Conversation

@gosar
Copy link
Contributor

@gosar gosar commented Oct 4, 2023

Motivation and Context

These tests don't work as-is in the testing branch where we default useSraAuth=true.

Modifications

So these tests work in both the feature branch and the testing branch where we default useSraAuth=true.

Testing

./mvnw clean install -pl :codegen

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license
So these tests work in both the feature branch and the testing branch where we default useSraAuth=true.
@gosar gosar requested a review from a team as a code owner October 4, 2023 01:22
@gosar gosar enabled auto-merge (squash) October 4, 2023 06:37
@gosar gosar merged commit e8c74e0 into feature/master/sra-identity-auth Oct 4, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 9 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 486 Code Smells

85.2% 85.2% Coverage
4.2% 4.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@gosar gosar deleted the gosar/sra-ia-codegen-useSraAuth-false branch October 4, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants