Skip to content

Commit b978c4c

Browse files
authored
Make s3control work with preSRA codegen (#4495)
* Add useSraAuth=true for SraIdentityResolutionTest * Make s3control work with preSRA codegen
1 parent 26d88e2 commit b978c4c

File tree

3 files changed

+1
-10
lines changed

3 files changed

+1
-10
lines changed

codegen/src/main/java/software/amazon/awssdk/codegen/poet/rules/EndpointResolverInterceptorSpec.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -536,11 +536,6 @@ private MethodSpec authSchemeWithEndpointSignerPropertiesMethod() {
536536

537537
method.beginControlFlow("for ($T endpointAuthScheme : endpointAuthSchemes)", EndpointAuthScheme.class);
538538

539-
// Don't include signer properties for auth options that don't match our selected auth scheme
540-
method.beginControlFlow("if (!endpointAuthScheme.schemeId().equals(selectedAuthScheme.authSchemeOption().schemeId()))");
541-
method.addStatement("continue");
542-
method.endControlFlow();
543-
544539
method.addStatement("$T option = selectedAuthScheme.authSchemeOption().toBuilder()", AuthSchemeOption.Builder.class);
545540

546541
if (dependsOnHttpAuthAws) {

codegen/src/test/resources/software/amazon/awssdk/codegen/poet/rules/endpoint-resolve-interceptor.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,9 +125,6 @@ private static void operationWithStaticContextParamsStaticContextParams(QueryEnd
125125
private <T extends Identity> SelectedAuthScheme<T> authSchemeWithEndpointSignerProperties(
126126
List<EndpointAuthScheme> endpointAuthSchemes, SelectedAuthScheme<T> selectedAuthScheme) {
127127
for (EndpointAuthScheme endpointAuthScheme : endpointAuthSchemes) {
128-
if (!endpointAuthScheme.schemeId().equals(selectedAuthScheme.authSchemeOption().schemeId())) {
129-
continue;
130-
}
131128
AuthSchemeOption.Builder option = selectedAuthScheme.authSchemeOption().toBuilder();
132129
if (endpointAuthScheme instanceof SigV4AuthScheme) {
133130
SigV4AuthScheme v4AuthScheme = (SigV4AuthScheme) endpointAuthScheme;

services/s3control/src/main/resources/codegen-resources/customization.config

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,5 @@
1919
"interceptors": [
2020
"software.amazon.awssdk.services.s3control.internal.interceptors.ConfigureSignerInterceptor",
2121
"software.amazon.awssdk.services.s3control.internal.interceptors.PayloadSigningInterceptor"
22-
],
23-
"useSraAuth": true
22+
]
2423
}

0 commit comments

Comments
 (0)