Skip to content

Conversation

@wty-Bryant
Copy link
Contributor

@wty-Bryant wty-Bryant commented Apr 11, 2025

v0.1 transfer manager v2's GetObject API needs user to initialize a concurrent reader and pass it to input for data downloading, this PR changed the concurrency design of new reader so user could call transfermanager.GetObject in the same way they call s3.GetObject and retrieve response data directly from output body like this:

svc := transfermanager.NewFromConfig(s3Client, cfg) out, err := svc.GetObject(ctx, input) written, err := io.Copy(dst, out.Body) 

Besides concurrency fix, this pr also add version control to DownloadObject and GetObject in the same way of #3050 in old transfer manager

@wty-Bryant wty-Bryant requested a review from a team as a code owner April 11, 2025 18:16
@wty-Bryant wty-Bryant changed the title Transfer Manager v2 downloader concurrency fix Transfer Manager v2 downloader concurrency fix and version control Apr 11, 2025
@wty-Bryant wty-Bryant force-pushed the feat-getobjectv2-migration branch from cd29641 to b9a2b9b Compare April 24, 2025 21:40
@wty-Bryant wty-Bryant merged commit 3aace41 into main Apr 25, 2025
13 checks passed
@wty-Bryant wty-Bryant deleted the feat-getobjectv2-migration branch April 25, 2025 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants