feat(glue): throw ValidationError instead of untyped errors (#35084)

### Issue # (if applicable) `aws-glue-alpha` for #32569 ### Description of changes ValidationErrors everywhere ### Describe any new or updated permissions being added N/A ### Description of how you validated changes Existing tests. Exemptions granted as this is basically a refactor of existing code. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

Author: mazyu36

packages/@aws-cdk/aws-glue-alpha/.eslintrc.js

@@ -4,5 +4,12 @@ baseConfig.parserOptions.project = __dirname + '/tsconfig.json';
 baseConfig.rules['import/no-extraneous-dependencies'] = ['error', { devDependencies: true, peerDependencies: true } ];
 baseConfig.rules['import/order'] = 'off';
 baseConfig.rules['@aws-cdk/invalid-cfn-imports'] = 'off';
+baseConfig.rules["@cdklabs/no-throw-default-error"] = ["error"];
+baseConfig.overrides.push({
+ files: ["./test/**"],
+ rules: {
+ "@cdklabs/no-throw-default-error": "off",
+ },
+});
 
 module.exports = baseConfig;

packages/@aws-cdk/aws-glue-alpha/lib/code.ts

@@ -66,7 +66,7 @@ export class AssetCode extends Code {
  super();
 
  if (fs.lstatSync(this.path).isDirectory()) {
- throw new Error(`Code path ${this.path} is a directory. Only files are supported`);
+ throw new cdk.UnscopedValidationError(`Code path ${this.path} is a directory. Only files are supported`);
  }
  }
 
@@ -78,7 +78,7 @@ export class AssetCode extends Code {
  ...this.options,
  });
  } else if (cdk.Stack.of(this.asset) !== cdk.Stack.of(scope)) {
- throw new Error(`Asset is already associated with another stack '${cdk.Stack.of(this.asset).stackName}'. ` +
+ throw new cdk.UnscopedValidationError(`Asset is already associated with another stack '${cdk.Stack.of(this.asset).stackName}'. ` +
  'Create a new Code instance for every stack.');
  }
  this.asset.grantRead(grantable);

packages/@aws-cdk/aws-glue-alpha/lib/database.ts

@@ -1,4 +1,4 @@
-import { ArnFormat, IResource, Lazy, Names, Resource, Stack } from 'aws-cdk-lib/core';
+import { ArnFormat, IResource, Lazy, Names, Resource, Stack, UnscopedValidationError } from 'aws-cdk-lib/core';
 import { Construct } from 'constructs';
 import { CfnDatabase } from 'aws-cdk-lib/aws-glue';
 import { addConstructMetadata } from 'aws-cdk-lib/core/lib/metadata-resource';
@@ -152,12 +152,12 @@ export class Database extends Resource implements IDatabase {
 
 function validateLocationUri(locationUri: string): void {
  if (locationUri.length < 1 || locationUri.length > 1024) {
- throw new Error(`locationUri length must be (inclusively) between 1 and 1024, got ${locationUri.length}`);
+ throw new UnscopedValidationError(`locationUri length must be (inclusively) between 1 and 1024, got ${locationUri.length}`);
  }
 }
 
 function validateDescription(description: string): void {
  if (description.length > 2048) {
- throw new Error(`description length must be less than or equal to 2048, got ${description.length}`);
+ throw new UnscopedValidationError(`description length must be less than or equal to 2048, got ${description.length}`);
  }
 }

packages/@aws-cdk/aws-glue-alpha/lib/external-table.ts

@@ -6,6 +6,7 @@ import { Column } from './schema';
 import { PartitionIndex, TableBase, TableBaseProps } from './table-base';
 import { addConstructMetadata, MethodMetadata } from 'aws-cdk-lib/core/lib/metadata-resource';
 import { propertyInjectable } from 'aws-cdk-lib/core/lib/prop-injectable';
+import { ValidationError } from 'aws-cdk-lib';
 
 export interface ExternalTableProps extends TableBaseProps {
  /**
@@ -90,7 +91,7 @@ export class ExternalTable extends TableBase {
  },
  parameters: props.storageParameters ? props.storageParameters.reduce((acc, param) => {
  if (param.key in acc) {
- throw new Error(`Duplicate storage parameter key: ${param.key}`);
+ throw new ValidationError(`Duplicate storage parameter key: ${param.key}`, this);
  }
  const key = param.key;
  acc[key] = param.value;

packages/@aws-cdk/aws-glue-alpha/lib/jobs/job.ts

@@ -488,7 +488,7 @@ export abstract class Job extends JobBase {
  const reservedArgs = new Set(['--debug', '--mode', '--JOB_NAME']);
  Object.keys(defaultArguments).forEach((arg) => {
  if (reservedArgs.has(arg)) {
- throw new Error(`The ${arg} argument is reserved by Glue. Don't set it`);
+ throw new cdk.ValidationError(`The ${arg} argument is reserved by Glue. Don't set it`, this);
  }
  });
  }

packages/@aws-cdk/aws-glue-alpha/lib/jobs/ray-job.ts

@@ -5,6 +5,7 @@ import { Construct } from 'constructs';
 import { JobType, GlueVersion, WorkerType, Runtime } from '../constants';
 import { addConstructMetadata } from 'aws-cdk-lib/core/lib/metadata-resource';
 import { propertyInjectable } from 'aws-cdk-lib/core/lib/prop-injectable';
+import { ValidationError } from 'aws-cdk-lib/core';
 
 /**
  * Properties for creating a Ray Glue job
@@ -77,7 +78,7 @@ export class RayJob extends Job {
  };
 
  if (props.workerType && props.workerType !== WorkerType.Z_2X) {
- throw new Error('Ray jobs only support Z.2X worker type');
+ throw new ValidationError('Ray jobs only support Z.2X worker type', this);
  }
 
  const jobResource = new CfnJob(this, 'Resource', {

packages/@aws-cdk/aws-glue-alpha/lib/jobs/scala-spark-etl-job.ts

@@ -5,6 +5,7 @@ import { Code } from '../code';
 import { SparkJob, SparkJobProps } from './spark-job';
 import { addConstructMetadata } from 'aws-cdk-lib/core/lib/metadata-resource';
 import { propertyInjectable } from 'aws-cdk-lib/core/lib/prop-injectable';
+import { ValidationError } from 'aws-cdk-lib/core';
 
 /**
  * Properties for creating a Scala Spark ETL job
@@ -89,7 +90,7 @@ export class ScalaSparkEtlJob extends SparkJob {
  };
 
  if ((!props.workerType && props.numberOfWorkers !== undefined) || (props.workerType && props.numberOfWorkers === undefined)) {
- throw new Error('Both workerType and numberOfWorkers must be set');
+ throw new ValidationError('Both workerType and numberOfWorkers must be set', this);
  }
 
  const jobResource = new CfnJob(this, 'Resource', {

packages/@aws-cdk/aws-glue-alpha/lib/jobs/scala-spark-streaming-job.ts

@@ -5,6 +5,7 @@ import { Code } from '../code';
 import { SparkJob, SparkJobProps } from './spark-job';
 import { addConstructMetadata } from 'aws-cdk-lib/core/lib/metadata-resource';
 import { propertyInjectable } from 'aws-cdk-lib/core/lib/prop-injectable';
+import { ValidationError } from 'aws-cdk-lib/core';
 
 /**
  * Properties for creating a Scala Spark ETL job
@@ -89,7 +90,7 @@ export class ScalaSparkStreamingJob extends SparkJob {
  };
 
  if ((!props.workerType && props.numberOfWorkers !== undefined) || (props.workerType && props.numberOfWorkers === undefined)) {
- throw new Error('Both workerType and numberOfWorkers must be set');
+ throw new ValidationError('Both workerType and numberOfWorkers must be set', this);
  }
 
  const jobResource = new CfnJob(this, 'Resource', {

packages/@aws-cdk/aws-glue-alpha/lib/jobs/spark-job.ts

@@ -4,7 +4,7 @@ import { addConstructMetadata } from 'aws-cdk-lib/core/lib/metadata-resource';
 import * as constructs from 'constructs';
 import { Code } from '../code';
 import { Job, JobProps } from './job';
-import { Token } from 'aws-cdk-lib';
+import { Token, UnscopedValidationError } from 'aws-cdk-lib';
 import { EOL } from 'os';
 
 /**
@@ -198,7 +198,7 @@ function validateSparkUiPrefix(prefix?: string): void {
  }
 
  if (errors.length > 0) {
- throw new Error(`Invalid prefix format (value: ${prefix})${EOL}${errors.join(EOL)}`);
+ throw new UnscopedValidationError(`Invalid prefix format (value: ${prefix})${EOL}${errors.join(EOL)}`);
  }
 }
 

packages/@aws-cdk/aws-glue-alpha/lib/s3-table.ts

@@ -7,6 +7,7 @@ import { Column } from './schema';
 import { PartitionIndex, TableBase, TableBaseProps } from './table-base';
 import { addConstructMetadata, MethodMetadata } from 'aws-cdk-lib/core/lib/metadata-resource';
 import { propertyInjectable } from 'aws-cdk-lib/core/lib/prop-injectable';
+import { UnscopedValidationError, ValidationError } from 'aws-cdk-lib';
 
 /**
  * Encryption options for a Table.
@@ -162,7 +163,7 @@ export class S3Table extends TableBase {
  },
  parameters: props.storageParameters ? props.storageParameters.reduce((acc, param) => {
  if (param.key in acc) {
- throw new Error(`Duplicate storage parameter key: ${param.key}`);
+ throw new ValidationError(`Duplicate storage parameter key: ${param.key}`, this);
  }
  const key = param.key;
  acc[key] = param.value;
@@ -264,7 +265,7 @@ function createBucket(table: S3Table, props: S3TableProps) {
  let bucket = props.bucket;
 
  if (bucket && (props.encryption !== undefined && props.encryption !== TableEncryption.CLIENT_SIDE_KMS)) {
- throw new Error('you can not specify encryption settings if you also provide a bucket');
+ throw new UnscopedValidationError('you can not specify encryption settings if you also provide a bucket');
  }
 
  const encryption = props.encryption || TableEncryption.S3_MANAGED;