Skip to content

Commit 5048c7d

Browse files
author
Zijun Wang
committed
Address PR comments: minor change
1 parent 2b19a8a commit 5048c7d

File tree

3 files changed

+1
-4
lines changed

3 files changed

+1
-4
lines changed

pkg/controllers/route_controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ import (
5858
var routeTypeToFinalizer = map[core.RouteType]string{
5959
core.HttpRouteType: "httproute.k8s.aws/resources",
6060
core.GrpcRouteType: "grpcroute.k8s.aws/resources",
61-
core.TlsRouteType: "tlsroute.k8s.aws/resource",
61+
core.TlsRouteType: "tlsroute.k8s.aws/resources",
6262
}
6363

6464
type routeReconciler struct {

test/suites/integration/tlsroute_serviceexport_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,10 +88,8 @@ var _ = Describe("TLSRoute Service Export/Import Test", Focus, Ordered, func() {
8888
Expect(*tg.Config.HealthCheck.Protocol).To(Equal("HTTPS"))
8989
Expect(*tg.Config.HealthCheck.ProtocolVersion).To(Equal("HTTP1"))
9090
Expect(*tg.Config.HealthCheck.Port).To(BeEquivalentTo(443))
91-
Expect(*tgSummary.Port).To(BeEquivalentTo(80))
9291
Eventually(func(g Gomega) {
9392
targets := testFramework.GetTargets(ctx, tgSummary, httpsDeployment1)
94-
g.Expect(*tgSummary.Port).To(BeEquivalentTo(80))
9593
for _, target := range targets {
9694
g.Expect(*target.Port).To(BeEquivalentTo(httpsSvc1.Spec.Ports[0].TargetPort.IntVal))
9795
g.Expect(*target.Status).To(Equal(vpclattice.TargetStatusHealthy))

test/suites/integration/tlsroute_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ var _ = Describe("TLSRoute test", Focus, Ordered, func() {
6969
Expect(*tg.Config.HealthCheck.Enabled).To(BeFalse())
7070
}
7171
targets := testFramework.GetTargets(ctx, tgSummary, httpsDeployment1)
72-
Expect(*tgSummary.Port).To(BeEquivalentTo(80))
7372
for _, target := range targets {
7473
Expect(*target.Port).To(BeEquivalentTo(httpsSvc1.Spec.Ports[0].TargetPort.IntVal))
7574
Expect(*target.Status).To(Equal(vpclattice.TargetStatusUnavailable))

0 commit comments

Comments
 (0)