fix(event-handler): multi-value query string and validation of scalar parameters #3795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pull-request-size bot added the size/L 
rubenfonseca changed the title 
rubenfonseca commented Feb 19, 2024
heitorlessa reviewed Feb 19, 2024
aws_lambda_powertools/utilities/data_classes/api_gateway_proxy_event.py Outdated Show resolved Hide resolved
heitorlessa reviewed Feb 19, 2024
heitorlessa reviewed Feb 19, 2024
tests/functional/event_handler/test_openapi_validation_middleware.py Outdated Show resolved Hide resolved
rubenfonseca force-pushed the rf/fix-single-params branch from 9762c66 to fe32522 Compare heitorlessa previously approved these changes Feb 19, 2024
|
Contributor Author
| @heitorlessa reasking for a review since I did a lot of changes |
heitorlessa approved these changes Feb 19, 2024
heitorlessa changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Issue number: #3732
Summary
Changes
This PR fixes a bug when validating scalar parameters. After the code we've introduced to handle multiple parameters, the code become inconsistent (notice the
Anytype) in that some resolvers return scalar parameters and some others returned a list of parameters.This caused problems when handling validation of scalar parameters. This code fixes that by ensuring the same behaviour in all event handlers, and updating the types accordingly.
User experience
This PR will fix the issue on #3732
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.