chore(deps): bump actions/upload-artifact from 3.1.3 to 4.3.1 #3714
Conversation
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3.1.3 to 4.3.1. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@a8a3f3a...5d5d22a) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot bot added dependencies 
boring-cyborg bot added the github-actions 
pull-request-size bot added the size/XS pull-request-size bot added size/S 
| @heitorlessa or @sthulb, I need your review here, pls! |
heitorlessa left a comment
heitorlessa left a comment There was a problem hiding this comment.
thank you <3 Waiting for Andrea to confirm whether overwrite was indeed all we needed before we merge.
heitorlessa left a comment
heitorlessa left a comment There was a problem hiding this comment.
preemptive approval on Andrea's confirmation
dreamorosi left a comment
dreamorosi left a comment There was a problem hiding this comment.
Overall, the fact that v4 of this action considers artifacts immutable means that it'll raise an exception whenever a given workflow tries to mutate (aka overwrite) an artifact with the same key.
If a workflow generates a single artifact or multiple artifacts with unique keys then it'll continue working. In both these cases the overwrite key is not needed and I'd be inclined to use the default behavior (aka treat artifacts as immutable).
It's important to note that an artifact is already considered unique in the context of a workflow run. This means that a workflow A that generates an artifact called foo.zip, when run twice, the two foo.zip are considered unique. This is because they were created in the context of two separate runs.
On the other hand, a workflow B, that has two steps that both write to an artifact called bar.zip, is considered to be mutating the same artifact because it writes twice to the same key within the same run.
With this in mind, I think the only workflow that needs the overwrite: true setting to be enabled is the layers one. The other 3 are only uploading an artifact as a terminal state of a run.
| Thanks for the clear explanation @dreamorosi! I am applying your suggestions. |
pull-request-size bot added size/XS 
|
| great call out on "v4 artifacts are now unique per job run"! Let me know when the changes are in and we can merge @leandrodamascena |
dreamorosi left a comment
dreamorosi left a comment There was a problem hiding this comment.
Thank you for working on this!
heitorlessa left a comment
heitorlessa left a comment There was a problem hiding this comment.
thank you Le for the changes!!
heitorlessa deleted the dependabot/github_actions/actions/upload-artifact-4.3.1 branch * develop: (21 commits) chore: cleanup, add test for single and nested fix(parameters): make cache aware of single vs multiple calls docs: Add nathan hanks post community (aws-powertools#3727) chore(deps-dev): bump isort from 5.11.5 to 5.13.2 (aws-powertools#3723) chore(deps-dev): bump cfn-lint from 0.83.8 to 0.85.0 (aws-powertools#3724) chore(deps): bump actions/download-artifact from 4.1.1 to 4.1.2 (aws-powertools#3725) chore(deps-dev): bump types-python-dateutil from 2.8.19.14 to 2.8.19.20240106 (aws-powertools#3720) chore(ci): enable Redis e2e tests (aws-powertools#3718) chore(deps-dev): bump pytest from 7.4.4 to 8.0.0 (aws-powertools#3711) chore(deps): bump actions/upload-artifact from 3.1.3 to 4.3.1 (aws-powertools#3714) chore(ci): changelog rebuild (aws-powertools#3715) chore(deps-dev): bump mypy from 1.4.1 to 1.8.0 (aws-powertools#3710) chore(deps-dev): bump httpx from 0.24.1 to 0.26.0 (aws-powertools#3712) chore(deps): bump actions/download-artifact from 3.0.2 to 4.1.1 (aws-powertools#3612) chore(deps): bump codecov/codecov-action from 3.1.6 to 4.0.1 (aws-powertools#3700) chore(deps-dev): bump coverage from 7.2.7 to 7.4.1 (aws-powertools#3713) chore(deps-dev): bump the boto-typing group with 7 updates (aws-powertools#3709) chore(deps): bump squidfunk/mkdocs-material from `a4a2029` to `e0d6c67` in /docs (aws-powertools#3708) chore(deps): bump release-drafter/release-drafter from 5.25.0 to 6.0.0 (aws-powertools#3699) chore(ci): drop support for Python 3.7 (aws-powertools#3638) ...
3 participants
Bumps actions/upload-artifact from 3.1.3 to 4.3.1.
Release notes
Sourced from actions/upload-artifact's releases.
Commits
5d5d22aMerge pull request #515 from actions/eggyhead/update-artifact-v2.1.1f1e993dupdate artifact license4881bfdupdating dist:a30777e@eggyhead3a80482Merge pull request #511 from actions/robherley/migration-docs-typo9d63e3fMerge branch 'main' into robherley/migration-docs-typodfa1ab2fix typo with v3 artifact downloads in migration guided00351bMerge pull request #509 from markmssd/patch-1707f5a7Update limitation of10artifacts upload to50026f96dfMerge pull request #505 from actions/robherley/merge-artifactsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)