Skip to content

Commit a4f8e24

Browse files
Juan Sotosindresorhus
authored andcommitted
Close #260 PR: Ignore possible test files under node_modules folder. Fixes #226.. Fixes #226
1 parent ffb750b commit a4f8e24

File tree

4 files changed

+17
-0
lines changed

4 files changed

+17
-0
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
node_modules
2+
!test/fixture/node_modules
23
.nyc_output
34
coverage

cli.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,8 @@ function handlePaths(files) {
207207
];
208208
}
209209

210+
files.push('!**/node_modules/**');
211+
210212
// convert pinkie-promise to Bluebird promise
211213
files = Promise.resolve(globby(files));
212214

test/cli.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -245,3 +245,11 @@ test('test file that immediately exits with 0 exit code ', function (t) {
245245
t.end();
246246
});
247247
});
248+
249+
test('test file in node_modules is ignored', function (t) {
250+
execCli('fixture/node_modules/test.js', function (err, stdout, stderr) {
251+
t.ok(err);
252+
t.true(/Couldn't find any files to test/.test(stderr));
253+
t.end();
254+
});
255+
});

test/fixture/node_modules/test.js

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)