Skip to content

Commit 6ef4a6f

Browse files
christophstroblmp911de
authored andcommitted
DATAREDIS-668 - Polishing.
Update comments, fix/add missing Javadoc and simplify implementation. Original pull request: spring-projects#259.
1 parent c87e0af commit 6ef4a6f

File tree

9 files changed

+1954
-1643
lines changed

9 files changed

+1954
-1643
lines changed

src/main/java/org/springframework/data/redis/connection/DefaultStringRedisConnection.java

Lines changed: 1664 additions & 1355 deletions
Large diffs are not rendered by default.

src/main/java/org/springframework/data/redis/connection/RedisSetCommands.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public interface RedisSetCommands {
7474
* Move {@code value} from {@code srcKey} to {@code destKey}
7575
*
7676
* @param srcKey must not be {@literal null}.
77-
* @param destKey must not be {@literal null}.
77+
* @param destKey must not be {@literal null}.
7878
* @param value
7979
* @return
8080
* @see <a href="http://redis.io/commands/smove">Redis Documentation: SMOVE</a>
@@ -84,7 +84,7 @@ public interface RedisSetCommands {
8484
/**
8585
* Get size of set at {@code key}.
8686
*
87-
* @param key must not be {@literal null}.
87+
* @param key must not be {@literal null}.
8888
* @return
8989
* @see <a href="http://redis.io/commands/scard">Redis Documentation: SCARD</a>
9090
*/
@@ -103,7 +103,7 @@ public interface RedisSetCommands {
103103
/**
104104
* Returns the members intersecting all given sets at {@code keys}.
105105
*
106-
* @param keys must not be {@literal null}.
106+
* @param keys must not be {@literal null}.
107107
* @return
108108
* @see <a href="http://redis.io/commands/sinter">Redis Documentation: SINTER</a>
109109
*/
@@ -132,7 +132,7 @@ public interface RedisSetCommands {
132132
* Union all sets at given {@code keys} and store result in {@code destKey}.
133133
*
134134
* @param destKey must not be {@literal null}.
135-
* @param keys must not be {@literal null}.
135+
* @param keys must not be {@literal null}.
136136
* @return
137137
* @see <a href="http://redis.io/commands/sunionstore">Redis Documentation: SUNIONSTORE</a>
138138
*/
@@ -169,7 +169,7 @@ public interface RedisSetCommands {
169169
/**
170170
* Get random element from set at {@code key}.
171171
*
172-
* @param key must not be {@literal null}.
172+
* @param key must not be {@literal null}.
173173
* @return
174174
* @see <a href="http://redis.io/commands/srandmember">Redis Documentation: SRANDMEMBER</a>
175175
*/

src/main/java/org/springframework/data/redis/connection/StringRedisConnection.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1289,7 +1289,7 @@ public interface StringTuple extends Tuple {
12891289
* @see <a href="http://redis.io/commands/zrangebyscore">Redis Documentation: ZRANGEBYSCORE</a>
12901290
* @see RedisZSetCommands#zRangeByScore(byte[], String, String)
12911291
*/
1292-
Set<byte[]> zRangeByScore(String key, String min, String max);
1292+
Set<String> zRangeByScore(String key, String min, String max);
12931293

12941294
/**
12951295
* Get elements in range from {@code start} to {@code end} where score is between {@code min} and {@code max} from
@@ -1305,7 +1305,7 @@ public interface StringTuple extends Tuple {
13051305
* @see <a href="http://redis.io/commands/zrangebyscore">Redis Documentation: ZRANGEBYSCORE</a>
13061306
* @see RedisZSetCommands#zRangeByScore(byte[], double, double, long, long)
13071307
*/
1308-
Set<byte[]> zRangeByScore(String key, String min, String max, long offset, long count);
1308+
Set<String> zRangeByScore(String key, String min, String max, long offset, long count);
13091309

13101310
/**
13111311
* Get all the elements in the sorted set at {@literal key} in lexicographical ordering.

0 commit comments

Comments
 (0)