Skip to content

Commit cca208c

Browse files
committed
v1.1.8
2 parents 7d21177 + f9d7e05 commit cca208c

31 files changed

+83
-49
lines changed

.eslintrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
"accessor-pairs": 2,
3838
"block-scoped-var": 2,
3939
"complexity": [2, 15],
40-
"consistent-return": 0,
40+
"consistent-return": 2,
4141
"curly": 2,
4242
"default-case": 1,
4343
"dot-location": 0,

Commands/init.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ var checkArtisan = function checkArtisan(cmdRes) {
2525
return new Promise(function promiseCheckArtisan(resolve, reject) {
2626
var test = cmdRes.match(/\s*Laravel\s+Framework\s+(version)?\s+(.*)/);
2727
if (test) {
28-
return resolve(test);
28+
resolve(test);
29+
return;
2930
}
3031
reject(new Error('not a laravel framework'));
3132
});
@@ -100,7 +101,7 @@ var writeConf = function writeConf() {
100101
comment += "*\n";
101102
comment += "* config:\n";
102103
comment += "* key: name of the config in laravel\n";
103-
comment += "* inport: - true import without ask\n";
104+
comment += "* import: - true import without ask\n";
104105
comment += "* - false don't import\n";
105106
comment += "* asis: true same as laravel\n";
106107
comment += "* false look for a file with the key name in lib/config folder\n";

Commands/laravelConfig.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
/* global app,appdir */
33
/* eslint global-require: 0 */
44

5-
var Promise = require('bluebird');
65
var shelljs = require('shelljs');
76
var utils = require('../lib/utilsCmd');
87
var fs = require('fs-promise');
@@ -20,7 +19,8 @@ var prepareTmpFolder = function prepareTmpFolder() {
2019
unsafeCleanup: true
2120
}, function tmpDirCallback(err, name) {
2221
if (err) {
23-
return reject(err);
22+
reject(err);
23+
return;
2424
}
2525
fs.mkdir(name + '/Config-laravel')
2626
.then(function tmpdirOk() {

Commands/missingJob.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,11 +92,13 @@ module.exports = {
9292
if (!app.config('app')) {
9393
res.red('app config missing').ln();
9494
res.yellow('see manual for setup config from laravel').ln();
95-
return res.prompt();
95+
res.prompt();
96+
return;
9697
}
9798
if (Object.keys(app.config('app.job', [])).length === 0) {
9899
res.yellow('no job in Config/app.js').ln();
99-
return res.prompt();
100+
res.prompt();
101+
return;
100102
}
101103
global.queueOption = {};
102104
Job = includeAll({

Commands/modelsCreator.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ module.exports = {
99
function: function run(req, res) {
1010
if (app.config('core.modelsCreator.models').length === 0) {
1111
res.yellow('Please add models to import in Config/core.js').ln();
12-
return res.prompt();
12+
res.prompt();
13+
return;
1314
}
1415
var dbModels = require('../lib/db-models');
1516
dbModels()

data/base/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/* eslint global-require: 0 */
22
try {
3-
require('laravel-queue/bootstrap/app');
3+
require('laravel-queue/bootstrap/app')();
44
} catch(e) {
55
console.log(e.message);
66
}

lib/Config.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
'use strict';
2-
/* global app */
32

43
var include = require('include-all');
54
var fs = require('fs');
@@ -30,7 +29,7 @@ var Config = function Config(appdir, logger) {
3029
Config.prototype.get = function get(key, def) {
3130
var reduce = function reduce(obj, index) {
3231
if (!obj) {
33-
return;
32+
return null;
3433
}
3534
return obj[index];
3635
};

lib/Mail.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
/* global appdir,app */
33
// var console = app.logger(config('core.log.prefix') + ':mail');
44

5-
var Promise = require('bluebird');
65
var ect = require('ect');
76
var defaults = require('lodash/defaults');
87
var nodemailer = require('nodemailer');
@@ -71,12 +70,15 @@ Mail.prototype.send = function sendMail(callback) {
7170
self.mailer.sendMail(mailOptions, function mailerSendMail(err, info) {
7271
if (err) {
7372
if (callback) {
74-
return callback(err);
73+
callback(err);
74+
return;
7575
}
76-
return reject(err);
76+
reject(err);
77+
return;
7778
}
7879
if (callback) {
79-
return callback(null, info);
80+
callback(null, info);
81+
return;
8082
}
8183
resolve(info);
8284
});

lib/db-models/lib/Model-export.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
'use strict';
22
/* global app */
33
/* eslint new-cap: 0*/
4-
var Promise = require('bluebird');
54
var console = app.logger(app.config('core.log.prefix') + ':model-export');
65
var _ = require('lodash');
76
_.mixin(require('lodash-inflection'));
@@ -29,13 +28,16 @@ ModelExport.prototype.createOutputDir = function createOutputDir() {
2928
return new Promise(function PromiseCreateOutputDir(resolve) {
3029
fs.stat(self.dir, function statDir(err, stats) {
3130
if (err || !stats.isDirectory()) {
32-
return fs.mkdir(self.dir, function mkdir(mkdirErr) {
31+
fs.mkdir(self.dir, function mkdir(mkdirErr) {
3332
if (!mkdirErr) {
34-
return resolve(true);
33+
resolve(true);
34+
return;
3535
}
3636
});
37+
return;
3738
}
38-
return resolve(true);
39+
resolve(true);
40+
return;
3941
});
4042
});
4143
};
@@ -105,7 +107,7 @@ ModelExport.prototype.createModels = function createModels() {
105107
}
106108
//for future association
107109
self.associate[lowerName] = modelName;
108-
return generatePromises.push(self.generateTemps({
110+
generatePromises.push(self.generateTemps({
109111
tableName: table,
110112
modelName: modelName,
111113
fields: results[1][table]

lib/shell/lib/Shell.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
'use strict';
2-
/* global app */
32
/*eslint no-magic-numbers: 0 */
43

54
var EventEmitter, Interface, Request, Response, shell, events, readline;
@@ -16,7 +15,7 @@ Interface = require('readline').Interface;
1615
var console;
1716

1817
Interface.prototype.setPrompt = (function setPrompt(parent) {
19-
return function returnSetPromt() {
18+
return function returnSetPrompt() {
2019
var args = Array.prototype.slice.call(arguments);
2120
if (!args[1]) {
2221
args[1] = Styles.unstyle(args[0]).length;
@@ -219,7 +218,7 @@ shell = (function exportShell(_super) {
219218
} else if (this.parent) {
220219
return this.parent.set(setting);
221220
}
222-
221+
return this;
223222
};
224223

225224
Shell.prototype.prompt = function prompt() {

0 commit comments

Comments
 (0)