fix(pairing): clarify Miller loop comment to reference P::ATE_LOOP_COUNT #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Forostovec requested review from Pratyush, mmagician and weikengchen and removed request for a team Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Updated the Miller loop comments in pairing modules for MNT4 and MNT6 to accurately describe the iteration over P::ATE_LOOP_COUNT.
The previous comment referenced a non-existent “mnt6_param_p” and implied iteration over a generic parameter p, which is misleading. The code actually iterates over P::ATE_LOOP_COUNT (signed in {-1, 0, 1}), skips the MSB, processes bits in MSB-to-LSB order, and applies a final correction when P::ATE_IS_LOOP_COUNT_NEG is true. No functional changes; docs only, for clarity and consistency with the implementation.