Apply changes from code review

Co-authored-by: Silvano Cerza <3314350+silvanocerza@users.noreply.github.com>

Author: cmaglie

cli/lib/check_deps.go

@@ -51,12 +51,12 @@ func runDepsCommand(cmd *cobra.Command, args []string) {
 os.Exit(errorcodes.ErrBadArgument)
 }
 
-deps, stat := lib.LibraryResolveDependencies(context.Background(), &rpc.LibraryResolveDependenciesRequest{
+deps, err := lib.LibraryResolveDependencies(context.Background(), &rpc.LibraryResolveDependenciesRequest{
 Instance: instance,
 Name: libRef.Name,
 Version: libRef.Version,
 })
-if stat != nil {
+if err != nil {
 feedback.Errorf(tr("Error resolving dependencies for %[1]s: %[2]s", libRef, err))
 }
 

commands/board/list.go

@@ -187,10 +187,10 @@ func List(req *rpc.BoardListRequest) (r []*rpc.DetectedPort, e error) {
 
 dm := pm.DiscoveryManager()
 if errs := dm.RunAll(); len(errs) > 0 {
-return nil, &commands.UnavailableError{Message: tr("Error starting board discoveries"), Cause: errs[0]}
+return nil, &commands.UnavailableError{Message: tr("Error starting board discoveries"), Cause: fmt.Errorf("%v", errs)}
 }
 if errs := dm.StartAll(); len(errs) > 0 {
-return nil, &commands.UnavailableError{Message: tr("Error starting board discoveries"), Cause: errs[0]}
+return nil, &commands.UnavailableError{Message: tr("Error starting board discoveries"), Cause: fmt.Errorf("%v", errs)}
 }
 defer func() {
 if errs := dm.StopAll(); len(errs) > 0 {
@@ -202,7 +202,7 @@ func List(req *rpc.BoardListRequest) (r []*rpc.DetectedPort, e error) {
 retVal := []*rpc.DetectedPort{}
 ports, errs := pm.DiscoveryManager().List()
 if len(errs) > 0 {
-return nil, &commands.UnavailableError{Message: tr("Error getting board list"), Cause: errs[0]}
+return nil, &commands.UnavailableError{Message: tr("Error getting board list"), Cause: fmt.Errorf("%v", errs)}
 }
 for _, port := range ports {
 boards, err := identify(pm, port)
@@ -231,7 +231,7 @@ func Watch(instanceID int32, interrupt <-chan bool) (<-chan *rpc.BoardListWatchR
 runErrs := dm.RunAll()
 if len(runErrs) == len(dm.IDs()) {
 // All discoveries failed to run, we can't do anything
-return nil, &commands.UnavailableError{Message: tr("Error starting board discoveries"), Cause: runErrs[0]}
+return nil, &commands.UnavailableError{Message: tr("Error starting board discoveries"), Cause: fmt.Errorf("%v", runErrs)}
 }
 
 eventsChan, errs := dm.StartSyncAll()

commands/upload/upload.go

@@ -237,9 +237,9 @@ func runProgramAction(pm *packagemanager.PackageManager,
 } else if programmer != nil {
 action = "program"
 }
-uploadToolID, st := getToolID(props, action, port.Protocol)
-if st != nil {
-return st
+uploadToolID, err := getToolID(props, action, port.Protocol)
+if err != nil {
+return err
 }
 
 var uploadToolPlatform *cores.PlatformRelease

commands/upload/upload_test.go

@@ -180,7 +180,7 @@ func TestUploadPropertiesComposition(t *testing.T) {
 testRunner := func(t *testing.T, test test, verboseVerify bool) {
 outStream := &bytes.Buffer{}
 errStream := &bytes.Buffer{}
-status := runProgramAction(
+err := runProgramAction(
 pm,
 nil, // sketch
 "", // importFile
@@ -201,9 +201,9 @@ func TestUploadPropertiesComposition(t *testing.T) {
 verboseVerifyOutput = "quiet noverify"
 }
 if test.expectedOutput == "FAIL" {
-require.NotNil(t, status)
+require.NotNil(t, err)
 } else {
-require.Nil(t, status)
+require.Nil(t, err)
 outFiltered := strings.ReplaceAll(outStream.String(), "\r", "")
 outFiltered = strings.ReplaceAll(outFiltered, "\\", "/")
 require.Contains(t, outFiltered, strings.ReplaceAll(test.expectedOutput, "$$VERBOSE-VERIFY$$", verboseVerifyOutput))