Skip to content

Commit d919e2e

Browse files
author
Justin Richer
committed
change from lists to sets
1 parent 65a7e1d commit d919e2e

File tree

1 file changed

+12
-8
lines changed

1 file changed

+12
-8
lines changed

openid-connect-common/src/main/java/org/mitre/openid/connect/service/ScopeClaimTranslationService.java

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
package org.mitre.openid.connect.service;
22

3-
import java.util.List;
3+
import java.util.HashSet;
44
import java.util.Map;
55
import java.util.Set;
66

7-
import com.google.common.collect.ArrayListMultimap;
8-
import com.google.common.collect.Lists;
7+
import com.google.common.collect.HashMultimap;
98
import com.google.common.collect.Maps;
9+
import com.google.common.collect.SetMultimap;
1010

1111
/**
1212
* Service to map scopes to claims, and claims to Java field names
@@ -16,7 +16,7 @@
1616
*/
1717
public class ScopeClaimTranslationService {
1818

19-
private ArrayListMultimap<String, String> scopesToClaims = ArrayListMultimap.create();
19+
private SetMultimap<String, String> scopesToClaims = HashMultimap.create();
2020
private Map<String, String> claimsToFields = Maps.newHashMap();
2121

2222
/**
@@ -76,12 +76,16 @@ public ScopeClaimTranslationService() {
7676

7777
}
7878

79-
public List<String> getClaimsForScope(String scope) {
80-
return scopesToClaims.get(scope);
79+
public Set<String> getClaimsForScope(String scope) {
80+
if (scopesToClaims.containsKey(scope)) {
81+
return scopesToClaims.get(scope);
82+
} else {
83+
return new HashSet<String>();
84+
}
8185
}
8286

83-
public List<String> getClaimsForScopeSet(Set<String> scopes) {
84-
List<String> result = Lists.newArrayList();
87+
public Set<String> getClaimsForScopeSet(Set<String> scopes) {
88+
Set<String> result = new HashSet<String>();
8589
for (String scope : scopes) {
8690
result.addAll(getClaimsForScope(scope));
8791
}

0 commit comments

Comments
 (0)