Skip to content

Commit 38eeac7

Browse files
committed
OAS-9904 Introduce ArangoDeployment Gateway Group
1 parent cd157ca commit 38eeac7

File tree

5 files changed

+8
-11
lines changed

5 files changed

+8
-11
lines changed

pkg/apis/shared/constants.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ const (
2525
ArangoPort = 8529
2626
ArangoSyncMasterPort = 8629
2727
ArangoSyncWorkerPort = 8729
28-
ArangoGatewayPort = 10000
2928
ArangoExporterPort = 9101
3029

3130
ArangoExporterStatusEndpoint = "/_api/version"

pkg/deployment/pod/utils.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ func GenerateMemberEndpoint(services service.Inspector, apiObject meta.Object, s
4343

4444
func GenerateMemberEndpointFromService(svc *core.Service, apiObject meta.Object, spec api.DeploymentSpec, group api.ServerGroup, member api.MemberStatus) (string, error) {
4545
switch group.Type() {
46-
case api.ServerGroupTypeArangoD:
46+
case api.ServerGroupTypeArangoD, api.ServerGroupGateways:
4747
switch method := spec.CommunicationMethod.Get(); method {
4848
case api.DeploymentCommunicationMethodDNS, api.DeploymentCommunicationMethodHeadlessDNS:
4949
return k8sutil.CreateServiceDNSNameWithDomain(svc, spec.ClusterDomain), nil

pkg/deployment/resources/pod_creator_gateway.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ func (a *ArangoGatewayContainer) GetName() string {
9090
}
9191

9292
func (a *ArangoGatewayContainer) GetPorts() []core.ContainerPort {
93-
port := shared.ArangoGatewayPort
93+
port := shared.ArangoPort
9494

9595
return []core.ContainerPort{
9696
{

pkg/deployment/resources/services.go

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,10 @@ func (r *Resources) EnsureServices(ctx context.Context, cachedStatus inspectorIn
8282
defer metrics.SetDuration(inspectServicesDurationGauges.WithLabelValues(deploymentName), start)
8383
counterMetric := inspectedServicesCounters.WithLabelValues(deploymentName)
8484

85+
if spec.IsGatewayEnabled() {
86+
role = api.ServerGroupGateways.AsRole()
87+
}
88+
8589
// Fetch existing services
8690
svcs := cachedStatus.ServicesModInterface().V1()
8791
amInspector := cachedStatus.ArangoMember().V1()
@@ -130,7 +134,7 @@ func (r *Resources) EnsureServices(ctx context.Context, cachedStatus inspectorIn
130134

131135
// Group Services
132136
for _, group := range api.AllServerGroups {
133-
if !group.Enabled(spec.GetMode()) {
137+
if !group.Enabled(spec.GetMode()) && !group.IsGateway() {
134138
continue
135139
}
136140

@@ -189,11 +193,6 @@ func (r *Resources) EnsureServices(ctx context.Context, cachedStatus inspectorIn
189193
counterMetric.Inc()
190194
headlessPorts, headlessSelector := k8sutil.HeadlessServiceDetails(deploymentName)
191195

192-
// todo
193-
/* if spec.IsGatewayEnabled() {
194-
// set headlessSelector to point to gateway
195-
}*/
196-
197196
if s, exists := cachedStatus.Service().V1().GetSimple(k8sutil.CreateHeadlessServiceName(deploymentName)); !exists {
198197
ctxChild, cancel := globals.GetGlobalTimeouts().Kubernetes().WithTimeout(ctx)
199198
defer cancel()
@@ -261,7 +260,6 @@ func (r *Resources) EnsureServices(ctx context.Context, cachedStatus inspectorIn
261260
return errors.WithStack(err)
262261
}
263262

264-
//todo
265263
if r.context.IsSyncEnabled() {
266264
// External (and internal) Sync master service
267265
counterMetric.Inc()

pkg/util/k8sutil/util.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ const (
4444
LabelKeyArangoScheduled = "deployment.arangodb.com/scheduled"
4545
// LabelKeyArangoTopology is the key of the label used to store the ArangoDeployment topology ID in
4646
LabelKeyArangoTopology = "deployment.arangodb.com/topology"
47-
// LabelKeyArangoLeader is the key of the label used to store the current leader of a group instances.
47+
// LabelKeyArangoLeader is the key of the label used to store the current leader of a group instances. AF only.
4848
LabelKeyArangoLeader = "deployment.arangodb.com/leader"
4949
// LabelKeyArangoActive is the key of the label used to mark members as active.
5050
LabelKeyArangoActive = "deployment.arangodb.com/active"

0 commit comments

Comments
 (0)