improved remote execution

Author: apsrcreatix

09-remote-command-execution-udp/client.c

@@ -20,22 +20,23 @@ Thanks.
 
 int main()
 {
- int serverDescriptor;
+ int serverDescriptor = socket(AF_INET, SOCK_DGRAM, 0);
  char buffer[MAX], message[MAX];
  struct sockaddr_in cliaddr, serverAddress;
  socklen_t serverLength = sizeof(serverAddress);
- bzero(&serverAddress, sizeof(serverAddress));
+
+ bzero(&serverAddress, sizeof(serverAddress));
  serverAddress.sin_family = AF_INET;
  serverAddress.sin_addr.s_addr = inet_addr("127.0.0.1");
  serverAddress.sin_port = htons(9976);
- serverDescriptor = socket(AF_INET, SOCK_DGRAM, 0);
- 
+
  bind(serverDescriptor, (struct sockaddr *)&serverAddress, sizeof(serverAddress));
+
  while (1)
  {
  printf("\nCOMMAND FOR EXECUTION ... ");
- fgets(buffer, 1024, stdin);
- sendto(serverDescriptor, buffer, sizeof(buffer), 0, (struct sockaddr *)&serverAddress,serverLength);
+ fgets(buffer, sizeof(buffer), stdin);
+ sendto(serverDescriptor, buffer, sizeof(buffer), 0, (struct sockaddr *)&serverAddress, serverLength);
  printf("\nData Sent !");
  recvfrom(serverDescriptor, message, sizeof(message), 0, (struct sockaddr *)&serverAddress, &serverLength);
  printf("UDP SERVER : %s", message);

09-remote-command-execution-udp/server.c

@@ -16,29 +16,30 @@ Thanks.
 #include <sys/stat.h>
 #include <arpa/inet.h>
 #include <unistd.h>
- #define MAX 1000
- int main(int argc, char *argv[]){
+#define MAX 1000
+int main()
+{
 
-  int serverDescriptor = socket(AF_INET, SOCK_DGRAM, 0);
-  int size;
-  char buffer[MAX], message[]="Command Successfully executed !";
-  struct sockaddr_in clientAddress, serverAddress;
+ int serverDescriptor = socket(AF_INET, SOCK_DGRAM, 0);
+ int size;
+ char buffer[MAX], message[] = "Command Successfully executed !";
+ struct sockaddr_in clientAddress, serverAddress;
 
-  socklen_t clientLength = sizeof(clientAddress);
+ socklen_t clientLength = sizeof(clientAddress);
 
-  bzero(&serverAddress, sizeof(serverAddress));
-  serverAddress.sin_family = AF_INET;
-  serverAddress.sin_addr.s_addr = htonl(INADDR_ANY);
-  serverAddress.sin_port = htons(9976);
+ bzero(&serverAddress, sizeof(serverAddress));
+ serverAddress.sin_family = AF_INET;
+ serverAddress.sin_addr.s_addr = htonl(INADDR_ANY);
+ serverAddress.sin_port = htons(9976);
 
-  bind(serverDescriptor, (struct sockaddr *)&serverAddress, sizeof(serverAddress));
-  while (1)
-  {
-  bzero(buffer, sizeof(buffer));
-  recvfrom(serverDescriptor, buffer, sizeof(buffer), 0, (struct sockaddr *)&clientAddress, &clientLength);
-  system(buffer);
-  sendto(serverDescriptor, message, sizeof(message), 0, (struct sockaddr *)&clientAddress, clientLength);
-  printf("Command Executed ... %s ", buffer);
+ bind(serverDescriptor, (struct sockaddr *)&serverAddress, sizeof(serverAddress));
+ while (1)
+ {
+ bzero(buffer, sizeof(buffer));
+ recvfrom(serverDescriptor, buffer, sizeof(buffer), 0, (struct sockaddr *)&clientAddress, &clientLength);
+ system(buffer);
+ printf("Command Executed ... %s ", buffer);
+ sendto(serverDescriptor, message, sizeof(message), 0, (struct sockaddr *)&clientAddress, clientLength);
  }
  close(serverDescriptor);
  return 0;