Remove dependency on swift-system #448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
neonichu requested review from MaxDesiatov, abertelrud and tomerd as code owners 
| @swift-ci please test |
MaxDesiatov approved these changes Nov 29, 2023
compnerd approved these changes Nov 29, 2023
| I think we can probably do the same PR for SwiftPM as well. |
| Hm, looks like swift-driver has some remnants of a swift-system dependency included which makes it impossible to fix SwiftPM. |
This dependency is unused and just unnecessarily complicates things.
| Hmm, in the binaries or in the build? The build is easy to repair. |
neonichu force-pushed the remove-swift-system branch from 84b660c to e2f2fe6 Compare | @swift-ci please test |
| @swift-ci please test windows |
1 similar comment
| @swift-ci please test windows |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This dependency is unused and just unnecessarily complicates things.