Add initial WebAssembly toolchain implementation #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @swift-ci please test |
owenv commented Oct 17, 2020
Comment on lines 16 to 22
| // On ELF/WASM platforms there's no built in autolinking mechanism, so we | ||
| // pull the info we need from the .o files directly and pass them as an | ||
| // argument input file to the linker. | ||
| // FIXME: Also handle Cygwin and MinGW | ||
| guard inputs.count > 0 && targetTriple.objectFormat == .elf && lto == nil else { | ||
| guard inputs.count > 0 && | ||
| [.elf, .wasm].contains(targetTriple.objectFormat) && | ||
| lto == nil else { |
There was a problem hiding this comment.
From what I understand we probably won't need autolink-extract for Wasm long-term, but this is pretty harmless in the meantime
owenv commented Oct 17, 2020
| public func makeLinkerOutputFilename(moduleName: String, type: LinkOutputType) -> String { | ||
| switch type { | ||
| case .executable: | ||
| return moduleName |
There was a problem hiding this comment.
not sure if this should always have the .wasm extension
owenv commented Oct 17, 2020
| cc @kateinoigakukun and @MaxDesiatov too |
MaxDesiatov approved these changes Oct 17, 2020
| @swift-ci please test |
| @swift-ci please test |
DougGregor approved these changes Oct 18, 2020
| The latest push fixes a small merge conflict, but otherwise there aren't any changes @swift-ci please test |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is an initial implementation of a WebAssembly toolchain. It shares a lot of similarities with the GenericUnixToolchain, but it doesn't support dynamic libraries and other features like sanitizers, profiling, etc. Overall, there are enough differences that trying to subclass GenericUnixToolchain seemed potentially error-prone.
The functionality in this PR goes a bit beyond the current Wasm support in the main Swift repo. I tested this change by installing swift-driver into a toolchain snapshot from the SwiftWasm fork and then verifying I could compile a basic working program.