Make sure to cancel listing when task is cancelled #966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Resolves apple#951 Verified that `DistributedReception.GuestListing.continuation.onTermination` closure gets invoked upon task cancellation, so listing subscription gets cancelled accordingly. Adding a test to make sure no further item is received from the listing.
ktoso reviewed Jun 10, 2022
| await call() | ||
| | ||
| // The single timer is done. Remove it so it can be installed again if needed. | ||
| self.cancel(for: key) |
Member
There was a problem hiding this comment.
This is called from another thread so we need to lock around all updates of internal var installedTimers: [TimerKey: DistributedActorTimer] = [:] now;
or we could turn this into an actor but since this type needs to go away anyway, let's just do the lock to keep it simple.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Resolves #951
Verified that
DistributedReception.GuestListing.continuation.onTerminationclosure gets invoked upon task cancellation, so listing subscription gets cancelled accordingly. Adding a test to make sure no further item is received from the listing.