Skip to content

Conversation

@yim-lee
Copy link
Member

@yim-lee yim-lee commented Jul 22, 2022

Part of #999

@ktoso
Copy link
Member

ktoso commented Jul 22, 2022

Sounds good! we don't need it public 👍

@yim-lee
Copy link
Member Author

yim-lee commented Jul 22, 2022

I considered moving VersionVector.proto to internal too but it would impact Membership and ClusterEvents so I left it.

@yim-lee yim-lee merged commit 5100fd1 into apple:main Jul 22, 2022
@yim-lee yim-lee deleted the hide-vv branch July 22, 2022 01:35
@ktoso
Copy link
Member

ktoso commented Jul 22, 2022

Hmmm... makin it internal might have been nice but it is _Proto prefixed so no big deal 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants