Commit fb67bfc
authored
Workaround SwiftPM API breakage checker limitation (#1211)
### Motivation In order to address a hanging integration test on newer Swift versions, #1208 added a target dependency on the executable used in the multi-node test plugin and stopped shelling out to `swift run`. This addressed the hang, but it has surfaced another issue: that SwiftPM's API breakage checker has issues with some packages that contain plugins, and now that pipeline is reproducibly resulting in false positives. ### Modifications This patch removes that dependency in the package manifest and reverts to running it from within the plugin. There was already code in the plugin to build the package and locate the required binary in the built artifacts, which I hadn't noticed in the previous patch, so the use of `swift run` seemed unnecessary. This patch just executes that found executable without `swift run`, which (hopefully) resolves both issues. ### Result: - Integration test should run to completion on all Swift versions (not hang on 6+) - API breakage pipeline should pass.1 parent 3b9eef6 commit fb67bfc
2 files changed
+10
-11
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
96 | | - | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
97 | 100 | | |
98 | 101 | | |
99 | 102 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
43 | | - | |
| 42 | + | |
44 | 43 | | |
45 | 44 | | |
46 | | - | |
| 45 | + | |
47 | 46 | | |
48 | 47 | | |
49 | 48 | | |
| |||
66 | 65 | | |
67 | 66 | | |
68 | 67 | | |
69 | | - | |
| 68 | + | |
70 | 69 | | |
71 | 70 | | |
72 | 71 | | |
73 | 72 | | |
74 | 73 | | |
75 | 74 | | |
76 | 75 | | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
| 76 | + | |
| 77 | + | |
82 | 78 | | |
83 | 79 | | |
84 | | - | |
| 80 | + | |
85 | 81 | | |
86 | 82 | | |
87 | 83 | | |
| |||
0 commit comments