Skip to content

Commit 1fe69b6

Browse files
[chart] remove default lifecycle value for backplane container (#51)
Removes default lifecycle with preStop hook for the backplane container. To my understanding this isn't respected and the backplane pod will terminate immediately if there are no requests being handled. The default value in the chart gives the impression it is being respected, and causes some confusion
1 parent 17aed3a commit 1fe69b6

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

deploy/helm/apoxy-gateway/templates/backplane_deployment.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,10 @@ spec:
9999
{{- with .Values.backplane.extraVolumeMounts }}
100100
{{- toYaml . | nindent 12 }}
101101
{{- end }}
102+
{{- with .Values.backplane.lifecycle }}
102103
lifecycle:
103-
{{- toYaml .Values.backplane.lifecycle | nindent 12 }}
104+
{{- toYaml . | nindent 12 }}
105+
{{- end }}
104106
# Set the termination grace period to the drain timeout plus a buffer
105107
# to allow for the proxy to finish draining connections.
106108
terminationGracePeriodSeconds: {{ .Values.backplane.proxy.drainTimeoutSeconds | add 5 }}

deploy/helm/apoxy-gateway/values.yaml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -114,11 +114,6 @@ backplane:
114114
rollingUpdate:
115115
maxUnavailable: 0
116116
maxSurge: 1
117-
118-
lifecycle:
119-
preStop:
120-
exec:
121-
command: ["/bin/sh", "-c", "sleep 15"]
122117

123118
controllerPodMonitor:
124119
enabled: false

0 commit comments

Comments
 (0)