[chart] remove default lifecycle value for backplane container (#51)

Removes default lifecycle with preStop hook for the backplane container. To my understanding this isn't respected and the backplane pod will terminate immediately if there are no requests being handled. The default value in the chart gives the impression it is being respected, and causes some confusion

Author: bryantanderson

deploy/helm/apoxy-gateway/templates/backplane_deployment.yaml

@@ -99,8 +99,10 @@ spec:
  {{- with .Values.backplane.extraVolumeMounts }}
  {{- toYaml . | nindent 12 }}
  {{- end }}
+ {{- with .Values.backplane.lifecycle }}
  lifecycle:
- {{- toYaml .Values.backplane.lifecycle | nindent 12 }}
+ {{- toYaml . | nindent 12 }}
+ {{- end }}
  # Set the termination grace period to the drain timeout plus a buffer
  # to allow for the proxy to finish draining connections.
  terminationGracePeriodSeconds: {{ .Values.backplane.proxy.drainTimeoutSeconds | add 5 }}

deploy/helm/apoxy-gateway/values.yaml

@@ -114,11 +114,6 @@ backplane:
  rollingUpdate:
  maxUnavailable: 0
  maxSurge: 1
-
- lifecycle:
- preStop:
- exec:
- command: ["/bin/sh", "-c", "sleep 15"]
 
  controllerPodMonitor:
  enabled: false