Skip to content

fix: ensure the Actor instance is initialized while calling its methods #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2025
Merged

fix: ensure the Actor instance is initialized while calling its methods #471

merged 2 commits into from
Sep 18, 2025

Conversation

barjin
Copy link
Contributor

@barjin barjin commented Sep 18, 2025 •
edited
Loading

Adds a warning on a non-initialized Actor on useState, exit, reboot and setStatusMessage method calls.
@barjin barjin self-assigned this Sep 18, 2025
@barjin barjin added the adhoc Ad-hoc unplanned task added during the sprint. label Sep 18, 2025
@barjin
Copy link
Contributor Author

barjin commented Sep 18, 2025 •
edited
Loading

Side note - Actor.exit(), Actor.reboot() and Actor.setStatusMessage() all use some components initialized in Actor.init() (storage client and / or event manager). Should we perhaps add the warnings to those too?
@github-actions github-actions bot added this to the 123rd sprint - Tooling team milestone Sep 18, 2025
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Sep 18, 2025
@barjin barjin requested a review from B4nan September 18, 2025 07:32
@B4nan
Copy link
Member

B4nan commented Sep 18, 2025

Side note - Actor.exit(), Actor.reboot() and Actor.setStatusMessage()

Good point, exit without init makes no sense, same for setStatusMessage, and likely too for the reboot method.
@barjin barjin changed the title fix: ensure the Actor instance is initialized on useState call fix: ensure the Actor instance is initialized while calling its methods Sep 18, 2025
@barjin barjin merged commit 70465f7 into master Sep 18, 2025
11 checks passed
@barjin barjin deleted the fix/use-state-init branch September 18, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

2 participants

@barjin @B4nan