feat: Use .reboot() instead of .metamorph() for reboot #227
Conversation
github-actions bot added t-core-services 
jirimoravcik requested review from B4nan and fnesveda and removed request for jancurn and mnmkng ![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request is neither linked to an issue or epic nor labeled as adhoc!
| const actorId = this.config.get('actorId')!; | ||
| await this.metamorph(actorId); | ||
| const runId = this.config.get('actorRunId')!; | ||
| await this.apifyClient.run(runId).reboot(); |
There was a problem hiding this comment.
We should sleep here after the API call, like we do with metamorph, so that the Actor waits for the reboot to happen (otherwise it could finish before the reboot happens).
There was a problem hiding this comment.
you're right, missed that, thanks
There was a problem hiding this comment.
Pull request is neither linked to an issue or epic nor labeled as adhoc!
| * @ignore | ||
| */ | ||
| async reboot(): Promise<void> { | ||
| async reboot(options: RebootOptions = {}): Promise<void> { |
There was a problem hiding this comment.
Pls can we describe the use case of reboot() in jsdoc here? E.g. if the actor gets into irrecoverable error state, it can just reboot itself and continue work where it left off.
fnesveda added the validated 4 participants
Closes #220