Skip to content

Commit 1f11a6a

Browse files
authored
fix: log status message only once and without prefix (#179)
1 parent 27edd99 commit 1f11a6a

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

packages/apify/src/actor.ts

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -250,13 +250,11 @@ export class Actor<Data extends Dictionary = Dictionary> {
250250

251251
if (options.exitCode > 0) {
252252
options.statusMessage ??= `Actor finished with an error (exit code ${options.exitCode})`;
253-
log.error(options.statusMessage);
254253
} else {
255254
options.statusMessage ??= `Actor finished successfully (exit code ${options.exitCode})`;
256-
log.info(options.statusMessage);
257255
}
258256

259-
await this.setStatusMessage(options.statusMessage, { isStatusMessageTerminal: true });
257+
await this.setStatusMessage(options.statusMessage, { isStatusMessageTerminal: true, level: options.exitCode > 0 ? LogLevel.ERROR : LogLevel.INFO });
260258

261259
if (!options.exit) {
262260
return;
@@ -519,20 +517,20 @@ export class Actor<Data extends Dictionary = Dictionary> {
519517
ow(statusMessage, ow.string);
520518
ow(isStatusMessageTerminal, ow.optional.boolean);
521519

522-
statusMessage = `[Status message]: ${statusMessage}`;
520+
const loggedStatusMessage = `[Status message]: ${statusMessage}`;
523521

524522
switch (level) {
525523
case LogLevel.DEBUG:
526-
log.debug(statusMessage);
524+
log.debug(loggedStatusMessage);
527525
break;
528526
case LogLevel.WARNING:
529-
log.warning(statusMessage);
527+
log.warning(loggedStatusMessage);
530528
break;
531529
case LogLevel.ERROR:
532-
log.error(statusMessage);
530+
log.error(loggedStatusMessage);
533531
break;
534532
default:
535-
log.info(statusMessage);
533+
log.info(loggedStatusMessage);
536534
break;
537535
}
538536

0 commit comments

Comments
 (0)