fix(graphql): do not add id field if operation already has a dedicated input type (#5095)

Co-authored-by: josef.wagner <josef.wagner@hf-solutions.co>

Author: jotwea

src/GraphQl/Type/FieldsBuilder.php

@@ -195,7 +195,7 @@ public function getResourceObjectTypeFields(?string $resourceClass, Operation $o
  return $fields;
  }
 
- if (!$input || 'create' !== $operation->getName()) {
+ if (!$input || ('create' !== $operation->getName() && !$operation->getInput())) {
  $fields['id'] = $idField;
  }
  if ($input && $depth >= 1) {

tests/GraphQl/Type/FieldsBuilderTest.php

@@ -697,6 +697,31 @@ public function resourceObjectTypeFieldsProvider(): array
  'clientMutationId' => GraphQLType::string(),
  ],
  ],
+ 'mutation using input DTO' => ['resourceClass', (new Mutation())->withName('mutation')->withInput(GraphQLType::string()),
+ [
+ 'property' => new ApiProperty(),
+ 'propertyBool' => (new ApiProperty())->withBuiltinTypes([new Type(Type::BUILTIN_TYPE_BOOL)])->withDescription('propertyBool description')->withReadable(false)->withWritable(true)->withDeprecationReason('not useful'),
+ 'propertySubresource' => (new ApiProperty())->withBuiltinTypes([new Type(Type::BUILTIN_TYPE_BOOL)])->withReadable(false)->withWritable(true),
+ ],
+ true, 0, null,
+ [
+ 'propertyBool' => [
+ 'type' => GraphQLType::nonNull(GraphQLType::string()),
+ 'description' => 'propertyBool description',
+ 'args' => [],
+ 'resolve' => null,
+ 'deprecationReason' => 'not useful',
+ ],
+ 'propertySubresource' => [
+ 'type' => GraphQLType::nonNull(GraphQLType::string()),
+ 'description' => null,
+ 'args' => [],
+ 'resolve' => null,
+ 'deprecationReason' => null,
+ ],
+ 'clientMutationId' => GraphQLType::string(),
+ ],
+ ],
  'mutation nested input' => ['resourceClass', (new Mutation())->withClass('resourceClass')->withName('mutation'),
  [
  'propertyBool' => (new ApiProperty())->withBuiltinTypes([new Type(Type::BUILTIN_TYPE_BOOL)])->withReadable(false)->withWritable(true),