fix pagination defaults and add tests

Author: GrimpEreau

src/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php

@@ -185,7 +185,7 @@ private function registerCommonConfiguration(ContainerBuilder $container, array
  $container->setParameter('api_platform.collection.exists_parameter_name', $config['collection']['exists_parameter_name']);
  $container->setParameter('api_platform.collection.order', $config['defaults']['order'] ?? $config['collection']['order']);
  $container->setParameter('api_platform.collection.order_parameter_name', $config['collection']['order_parameter_name']);
- $container->setParameter('api_platform.collection.pagination.enabled', $this->isConfigEnabled($container, $config['defaults']['pagination_enabled'] ?? $config['collection']['pagination']));
+ $container->setParameter('api_platform.collection.pagination.enabled', $config['api_platform']['defaults'] ?? $this->isConfigEnabled($container, $config['collection']['pagination']));
  $container->setParameter('api_platform.collection.pagination.partial', $config['defaults']['pagination_partial'] ?? $config['collection']['pagination']['partial']);
  $container->setParameter('api_platform.collection.pagination.client_enabled', $config['defaults']['pagination_client_enabled'] ?? $config['collection']['pagination']['client_enabled']);
  $container->setParameter('api_platform.collection.pagination.client_items_per_page', $config['defaults']['pagination_client_items_per_page'] ?? $config['collection']['pagination']['client_items_per_page']);

tests/Bridge/Symfony/Bundle/DependencyInjection/ApiPlatformExtensionTest.php

@@ -786,6 +786,22 @@ public function testDisabledSwagger()
  $this->extension->load($config, $containerBuilder);
  }
 
+ public function testPaginationEnabledViaDefaults()
+ {
+ $config = self::DEFAULT_CONFIG;
+ $config['api_platform']['defaults'] = [
+ 'attributes' => [
+ 'pagination' => true
+ ],
+ ];
+
+ $containerBuilderProphecy = $this->getBaseContainerBuilderProphecy();
+ $containerBuilderProphecy->setParameter('api_platform.defaults', ['attributes' => ['pagination' => true]])->shouldBeCalled();
+ $containerBuilderProphecy->setParameter('api_platform.defaults', ['attributes' => []])->shouldNotBeCalled();
+ $containerBuilder = $containerBuilderProphecy->reveal();
+ $this->extension->load($config, $containerBuilder);
+ }
+
  private function getPartialContainerBuilderProphecy($configuration = null)
  {
  $parameterBag = new EnvPlaceholderParameterBag();