- Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-29622 : Flaky Test in TestBackupDelete #7364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java Outdated Show resolved Hide resolved
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupAdminImpl.java Outdated Show resolved Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ed431a7 to 26fe40d Compare | 🎊 +1 overall
This message was automatically generated. |
| 💔 -1 overall
This message was automatically generated. |
| 🎊 +1 overall
This message was automatically generated. |
| 🎊 +1 overall
This message was automatically generated. |
vaijosh left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupAdminImpl.java Show resolved Hide resolved
26fe40d to d39879c Compare | recheck |
| 💔 -1 overall
This message was automatically generated. |
| 💔 -1 overall
This message was automatically generated. |
1 similar comment
| 💔 -1 overall
This message was automatically generated. |
| 💔 -1 overall
This message was automatically generated. |
9713f00 to f899ed5 Compare | 🎊 +1 overall
This message was automatically generated. |
| 🎊 +1 overall
This message was automatically generated. |
| 💔 -1 overall
This message was automatically generated. |
| 🎊 +1 overall
This message was automatically generated. |
| 🎊 +1 overall
This message was automatically generated. |
| 🎊 +1 overall
This message was automatically generated. |
| 🎊 +1 overall
This message was automatically generated. |
| 🎊 +1 overall
This message was automatically generated. |
testBackupDeleteUpdatesIncrementalBackupSet is flaky.
BackupAdminImpl.finalizeDelete() method first deletes Incremental table set in BackupSystemTable and then updates it with new Incremental table set. In this process race condition is occuring between Delete and Put calls.
In a very rare scenario, These Delete and Put Objects are having same timestamps and because of that We're encountering Lost Update error. Because of this Result of Get call is empty for same row key and We're having assertion failure.