Skip to content

Conversation

@p-szucs
Copy link
Contributor

@p-szucs p-szucs commented Nov 7, 2025

Change-Id: I7c08bd438fe17dfed8641f6883d8dbc9566fc771

Description of PR

In GenericExceptionHandler's toResponse method we put only the exception message into the RemoteExceptionData object.

It would be a bit more informative if we would use throwable.toString() instead of throwable.getMessage() as the former extends the error message with the exception class as well, similarly to previous versions.

How was this patch tested?

Tested on a Hadoop cluster

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?
Change-Id: I7c08bd438fe17dfed8641f6883d8dbc9566fc771
@K0K0V0K
Copy link
Contributor

K0K0V0K commented Nov 7, 2025

Thanks @p-szucs for the fix! Seems good to me. If you can add some basic unit test as well, that would be great!

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 21m 38s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 33m 5s trunk passed
+1 💚 compile 0m 46s trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 compile 0m 46s trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 checkstyle 0m 36s trunk passed
+1 💚 mvnsite 0m 50s trunk passed
+1 💚 javadoc 0m 55s trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 50s trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
-1 ❌ spotbugs 2m 40s /branch-spotbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 1100 extant spotbugs warnings.
+1 💚 shadedclient 27m 59s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 40s the patch passed
+1 💚 compile 0m 38s the patch passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 javac 0m 38s the patch passed
+1 💚 compile 0m 37s the patch passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 javac 0m 37s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 24s the patch passed
+1 💚 mvnsite 0m 41s the patch passed
+1 💚 javadoc 0m 44s the patch passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 41s the patch passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚 spotbugs 2m 40s the patch passed
+1 💚 shadedclient 27m 36s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 5m 28s hadoop-yarn-common in the patch passed.
+1 💚 asflicense 0m 35s The patch does not generate ASF License warnings.
130m 1s
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8066/1/artifact/out/Dockerfile
GITHUB PR #8066
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux c802eee51362 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / b2e0d30
Default Java Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
Multi-JDK versions /usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8066/1/testReport/
Max. process+thread count 628 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8066/1/console
versions git=2.25.1 maven=3.9.11 spotbugs=4.9.7
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Change-Id: Ifb57f9b4f4acf7965f414954e9e93e88ce300233
@slfan1989
Copy link
Contributor

@p-szucs Thanks for the contribution! Since some changes touch the MapReduce module, I suggest splitting this into two PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment