YARN-11262. Fix CheckStyle.

Author: slfan1989

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/security/TestAMRMTokens.java

@@ -302,8 +302,7 @@ public void testMasterKeyRollOver(Configuration pConf) throws Exception {
 
  MasterKeyData newKey = appTokenSecretManager.getMasterKey();
  assertNotNull(newKey);
- assertFalse(
- oldKey.equals(newKey), "Master key should have changed!");
+ assertFalse(oldKey.equals(newKey), "Master key should have changed!");
 
  // Another allocate call with old AMRMToken. Should continue to work.
  rpc.stopProxy(rmClient, conf); // To avoid using cached client

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/security/TestDelegationTokenRenewer.java

@@ -494,7 +494,7 @@ public void testDTRenewal () throws Exception {
  ";Counter = " + Renewer.counter + ";t="+ Renewer.lastRenewed);
  assertEquals(numberOfExpectedRenewals, Renewer.counter,
  "renew wasn't called as many times as expected(4):");
- assertEquals(Renewer.lastRenewed, 
+ assertEquals(Renewer.lastRenewed,
  token1, "most recently renewed token mismatch");
 
  // Test 2. 
@@ -943,7 +943,7 @@ public void testDTRonAppSubmission()
 
  }
 
- @Test 
+ @Test
  @Timeout(value = 20)
  public void testConcurrentAddApplication() 
  throws IOException, InterruptedException, BrokenBarrierException { 

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/volume/csi/TestVolumeCapabilityRange.java

@@ -32,32 +32,32 @@ public class TestVolumeCapabilityRange {
  @Test
  public void testInvalidMinCapability() throws InvalidVolumeException {
  assertThrows(InvalidVolumeException.class, () -> {
- VolumeCapabilityRange.newBuilder()
- .minCapacity(-1L)
- .maxCapacity(5L)
- .unit("Gi")
- .build();
+  VolumeCapabilityRange.newBuilder()
+  .minCapacity(-1L)
+  .maxCapacity(5L)
+  .unit("Gi")
+  .build();
  });
  }
 
  @Test
  public void testMissingMinCapability() throws InvalidVolumeException {
  assertThrows(InvalidVolumeException.class, () -> {
- VolumeCapabilityRange.newBuilder()
- .maxCapacity(5L)
- .unit("Gi")
- .build();
+  VolumeCapabilityRange.newBuilder()
+  .maxCapacity(5L)
+  .unit("Gi")
+  .build();
  });
 
  }
 
  @Test
  public void testMissingUnit() throws InvalidVolumeException {
  assertThrows(InvalidVolumeException.class, () -> {
- VolumeCapabilityRange.newBuilder()
- .minCapacity(0L)
- .maxCapacity(5L)
- .build();
+  VolumeCapabilityRange.newBuilder()
+  .minCapacity(0L)
+  .maxCapacity(5L)
+  .build();
  });
  }
 

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServices.java

@@ -528,11 +528,10 @@ public void verifyClusterMetrics(int submittedApps, int completedApps,
 
  assertEquals(0, containersAlloc, "containersAllocated doesn't match");
  assertEquals(totalMBExpect, totalMB, "totalMB doesn't match");
- assertEquals(
- clusterMetrics.getNumActiveNMs() + clusterMetrics.getNumLostNMs()
- + clusterMetrics.getNumDecommisionedNMs()
- + clusterMetrics.getNumRebootedNMs()
- + clusterMetrics.getUnhealthyNMs(), totalNodes, "totalNodes doesn't match");
+ assertEquals(clusterMetrics.getNumActiveNMs() + clusterMetrics.getNumLostNMs()
+ + clusterMetrics.getNumDecommisionedNMs()
+ + clusterMetrics.getNumRebootedNMs()
+ + clusterMetrics.getUnhealthyNMs(), totalNodes, "totalNodes doesn't match");
  assertEquals(clusterMetrics.getNumLostNMs(), lostNodes, "lostNodes doesn't match");
  assertEquals(clusterMetrics.getUnhealthyNMs(), unhealthyNodes,
  "unhealthyNodes doesn't match");

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesApps.java

@@ -405,7 +405,7 @@ public void testAppsQueryStatesComma() throws JSONException, Exception {
  array = apps.getJSONArray("app");
  assertEquals(2, array.length(), "incorrect number of elements");
  assertTrue(
- (array.getJSONObject(0).getString("state").equals("ACCEPTED") &&
+  (array.getJSONObject(0).getString("state").equals("ACCEPTED") &&
  array.getJSONObject(1).getString("state").equals("KILLED")) ||
  (array.getJSONObject(0).getString("state").equals("KILLED") &&
  array.getJSONObject(1).getString("state").equals("ACCEPTED")),
@@ -1869,7 +1869,7 @@ public void verifyAppInfoGeneric(RMApp app, String id, String user,
  state);
  WebServicesTestUtils.checkStringMatch("finalStatus", app
  .getFinalApplicationStatus().toString(), finalStatus);
- assertEquals( 0, progress, 0.0, "progress doesn't match");
+ assertEquals(0, progress, 0.0, "progress doesn't match");
  if ("UNASSIGNED".equals(trackingUI)) {
  WebServicesTestUtils.checkStringMatch("trackingUI", "UNASSIGNED",
  trackingUI);
@@ -1939,8 +1939,8 @@ public void verifyResourceRequestsGeneric(ResourceRequest request,
  String nodeLabelExpression, int numContainers, boolean relaxLocality,
  int priority, String resourceName, long memory, long vCores,
  String executionType, boolean enforceExecutionType) {
- assertEquals(
- request.getNodeLabelExpression(), nodeLabelExpression, "nodeLabelExpression doesn't match");
+ assertEquals(request.getNodeLabelExpression(), nodeLabelExpression,
+ "nodeLabelExpression doesn't match");
  assertEquals(request.getNumContainers(),
  numContainers, "numContainers doesn't match");
  assertEquals(request.getRelaxLocality(),

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesAppsModification.java

@@ -501,8 +501,8 @@ public void testSingleAppKill(int run) throws Exception {
  } else {
  verifyAppStateXML(response, RMAppState.KILLED);
  }
- assertTrue(
- app.getDiagnostics().toString().contains(diagnostic), "Diagnostic message is incorrect");
+ assertTrue(app.getDiagnostics().toString().contains(diagnostic),
+ "Diagnostic message is incorrect");
  break;
  }
  }

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesCapacitySchedDefaultLabel.java

@@ -102,7 +102,7 @@ public void setUp() throws Exception {
  }
 
  public void initTestRMWebServicesCapacitySchedDefaultLabel(boolean pLegacyQueueMode)
- throws Exception {
+  throws Exception {
  this.legacyQueueMode = pLegacyQueueMode;
  backupSchedulerConfigFileInTarget();
  setUp();

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesConfigurationMutation.java

@@ -409,8 +409,8 @@ public void testUnsetParentQueueOrderingPolicy() throws Exception {
  .getConfiguration();
  bOrderingPolicy = CapacitySchedulerConfiguration.PREFIX
  + "root.b" + CapacitySchedulerConfiguration.DOT + ORDERING_POLICY;
- assertNull(
- newCSConf.get(bOrderingPolicy), "Failed to unset Parent Queue OrderingPolicy");
+ assertNull(newCSConf.get(bOrderingPolicy),
+ "Failed to unset Parent Queue OrderingPolicy");
  }
 
  @Test
@@ -453,8 +453,8 @@ public void testUnsetLeafQueueOrderingPolicy() throws Exception {
  .getConfiguration();
  cOrderingPolicy = CapacitySchedulerConfiguration.PREFIX
  + "root.c" + CapacitySchedulerConfiguration.DOT + ORDERING_POLICY;
- assertNull(
- newCSConf.get(cOrderingPolicy), "Failed to unset Leaf Queue OrderingPolicy");
+ assertNull(newCSConf.get(cOrderingPolicy),
+ "Failed to unset Leaf Queue OrderingPolicy");
  }
 
  @Test
@@ -477,8 +477,8 @@ public void testRemoveQueue() throws Exception {
  assertEquals(Status.OK.getStatusCode(), response.getStatus());
  CapacitySchedulerConfiguration newCSConf =
  ((CapacityScheduler) rm.getResourceScheduler()).getConfiguration();
- assertEquals(
- 1, newCSConf.getQueues(ROOT_A).size(), "Failed to remove the queue");
+ assertEquals(1, newCSConf.getQueues(ROOT_A).size(),
+ "Failed to remove the queue");
  assertEquals("a1", newCSConf.getQueues(ROOT_A).get(0),
  "Failed to remove the right queue");
  }
@@ -520,8 +520,8 @@ public void testRemoveQueueWhichHasQueueMapping() throws Exception {
  CapacityScheduler cs = (CapacityScheduler) rm.getResourceScheduler();
 
  // Validate Queue 'mappedqueue' exists before deletion
- assertNotNull(
- cs.getQueue("mappedqueue"), "Failed to setup CapacityScheduler Configuration");
+ assertNotNull(cs.getQueue("mappedqueue"),
+ "Failed to setup CapacityScheduler Configuration");
 
  // Set state of queue 'mappedqueue' to STOPPED.
  SchedConfUpdateInfo updateInfo = new SchedConfUpdateInfo();
@@ -547,8 +547,8 @@ public void testRemoveQueueWhichHasQueueMapping() throws Exception {
  CapacitySchedulerConfiguration newCSConf =
  ((CapacityScheduler) rm.getResourceScheduler()).getConfiguration();
  assertEquals(4, newCSConf.getQueues(ROOT).size());
- assertNotNull(
- cs.getQueue("mappedqueue"), "CapacityScheduler Configuration is corrupt");
+ assertNotNull(cs.getQueue("mappedqueue"),
+ "CapacityScheduler Configuration is corrupt");
  }
 
  @Test

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesForCSWithPartitions.java

@@ -470,8 +470,7 @@ private void verifyQueueAInfoXML(Element queueElem) {
  Element partitionCapacitiesInfo = (Element) capacitiesListInfos.item(0);
  String partitionName = WebServicesTestUtils
  .getXmlString(partitionCapacitiesInfo, "partitionName");
- assertTrue(
- partitionName.isEmpty(), "invalid PartitionCapacityInfo");
+ assertTrue(partitionName.isEmpty(), "invalid PartitionCapacityInfo");
  verifyPartitionCapacityInfoXML(partitionCapacitiesInfo, 30, 0, 50, 30,
  0, 50);
  } else if (queueChildElem.getTagName().equals("resources")) {
@@ -610,7 +609,7 @@ private void verifyPartitionCapacityInfoXML(Element partitionInfo,
  assertEquals(capacity, WebServicesTestUtils.getXmlFloat(partitionInfo, "capacity"),
  EPSILON, "capacity doesn't match");
  assertEquals(usedCapacity, WebServicesTestUtils.getXmlFloat(partitionInfo, "usedCapacity"),
- EPSILON,"capacity doesn't match");
+ EPSILON, "capacity doesn't match");
  assertEquals(maxCapacity, WebServicesTestUtils.getXmlFloat(partitionInfo, "maxCapacity"),
  EPSILON, "capacity doesn't match");
  assertEquals(absoluteCapacity,
@@ -813,14 +812,14 @@ private void verifyPartitionCapacityInfoJson(
  JSONObject partitionCapacityInfoJson, float capacity, float usedCapacity,
  float maxCapacity, float absoluteCapacity, float absoluteUsedCapacity,
  float absoluteMaxCapacity) throws JSONException {
- assertEquals(capacity,
- (float) partitionCapacityInfoJson.getDouble("capacity"), EPSILON, "capacity doesn't match");
- assertEquals(usedCapacity,
- (float) partitionCapacityInfoJson.getDouble("usedCapacity"), EPSILON, "capacity doesn't match");
- assertEquals(maxCapacity,
- (float) partitionCapacityInfoJson.getDouble("maxCapacity"), EPSILON, "capacity doesn't match");
- assertEquals(absoluteCapacity,
- (float) partitionCapacityInfoJson.getDouble("absoluteCapacity"), EPSILON, "capacity doesn't match");
+ assertEquals(capacity, (float) partitionCapacityInfoJson.getDouble("capacity"),
+ EPSILON, "capacity doesn't match");
+ assertEquals(usedCapacity, (float) partitionCapacityInfoJson.getDouble("usedCapacity"),
+ EPSILON, "capacity doesn't match");
+ assertEquals(maxCapacity, (float) partitionCapacityInfoJson.getDouble("maxCapacity"),
+ EPSILON, "capacity doesn't match");
+ assertEquals(absoluteCapacity, (float) partitionCapacityInfoJson.getDouble("absoluteCapacity"),
+ EPSILON, "capacity doesn't match");
  assertEquals(absoluteUsedCapacity,
  (float) partitionCapacityInfoJson.getDouble("absoluteUsedCapacity"),
  1e-3f, "capacity doesn't match");

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/TestRMWebServicesReservation.java

@@ -495,7 +495,8 @@ public void testTimeIntervalRequestListReservation(int run, boolean recurrence)
 
  @MethodSource("guiceConfigs")
  @ParameterizedTest
- public void testSameTimeIntervalRequestListReservation(int run, boolean recurrence) throws Exception {
+ public void testSameTimeIntervalRequestListReservation(int run, boolean recurrence)
+ throws Exception {
  initTestRMWebServicesReservation(run, recurrence);
  rm.start();
  setupCluster(100);
@@ -693,7 +694,8 @@ public void testEmptyEndTimeRequestListReservation(int run, boolean recurrence)
 
  @MethodSource("guiceConfigs")
  @ParameterizedTest
- public void testInvalidStartTimeRequestListReservation(int run, boolean recurrence) throws Exception {
+ public void testInvalidStartTimeRequestListReservation(int run, boolean recurrence)
+ throws Exception {
  initTestRMWebServicesReservation(run, recurrence);
  rm.start();
  setupCluster(100);
@@ -739,7 +741,8 @@ public void testInvalidStartTimeRequestListReservation(int run, boolean recurren
 
  @MethodSource("guiceConfigs")
  @ParameterizedTest
- public void testEmptyStartTimeRequestListReservation(int run, boolean recurrence) throws Exception {
+ public void testEmptyStartTimeRequestListReservation(int run, boolean recurrence)
+ throws Exception {
  initTestRMWebServicesReservation(run, recurrence);
  rm.start();
  setupCluster(100);
@@ -862,7 +865,8 @@ public void testNonExistentQueueRequestListReservation(int run, boolean recurren
 
  @MethodSource("guiceConfigs")
  @ParameterizedTest
- public void testReservationIdRequestListReservation(int run, boolean recurrence) throws Exception {
+ public void testReservationIdRequestListReservation(int run, boolean recurrence)
+ throws Exception {
  initTestRMWebServicesReservation(run, recurrence);
  rm.start();
  setupCluster(100);