Skip to content

Include dependencies in POM and publish Gradle module JSON #15113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Include dependencies in POM and publish Gradle module JSON #15113

wants to merge 1 commit into from

Conversation

@jamesfredley
Copy link
Contributor

@jamesfredley jamesfredley commented Oct 4, 2025

Set skipJavaComponent to false in assets, starter-web, and test build.gradle files to include Java component configuration in these Grails meta-projects.

The publication must be a proper Java component to publish the Gradle module json file.

Resolves: #15110
@jamesfredley
Include dependencies in POM and publish Gradle module JSON
8bbcc90 
Set skipJavaComponent to false in assets, starter-web, and test build.gradle files to include Java component configuration in these Grails meta-projects. The publication must be a proper Java component to publish the Gradle module json file.
@jamesfredley jamesfredley added this to the grails:7.0.0 milestone Oct 4, 2025
@jamesfredley jamesfredley self-assigned this Oct 4, 2025
@jamesfredley jamesfredley moved this to In Progress in Apache Grails Oct 4, 2025
matrei
matrei approved these changes Oct 4, 2025
View reviewed changes
Copy link
Contributor

@matrei matrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another option would be to remove the property setting.
But in this case maybe it is better to set the property and add a comment why it is explicitly set to false.
matrei
matrei reviewed Oct 4, 2025
View reviewed changes
Copy link
Contributor

@matrei matrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I think a bit more about this, I'm not sure why the skipJavaComponent property was added and if this defeats it's purpose in some other area.

I think @jdaugherty would be able to answer that as he introduced skipJavaComponent.
@jdaugherty
Copy link
Contributor

jdaugherty commented Oct 4, 2025

So i have been working on another
change to move all of this. I would prefer we wait to merge this because this is changing code I have already touched.

The core issue is there is a bug where we were publishing empty jar files with just asf policy files.
@jdaugherty
Copy link
Contributor

jdaugherty commented Oct 5, 2025 •
edited
Loading

Made obsolete by #15114
@jamesfredley
Copy link
Contributor Author

jamesfredley commented Oct 6, 2025

#15114 fully addresses #15110, so close this PR.
@github-project-automation github-project-automation bot moved this from In Progress to Done in Apache Grails Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci maintenance

3 participants

@jamesfredley @jdaugherty @matrei