Add profile support for Gradle dependency variants #15013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Enhanced ProfileUtil and GradleDependency to support Gradle dependency variants (e.g., platform()) in profile definitions. Updated profile.yml files to move variant and devtools dependencies from build.gradle into the profile metadata, and added integration test dependency to the web profile. This change improves consistency and flexibility in dependency management for Grails profiles.
dauer approved these changes Aug 26, 2025
Contributor
dauer left a comment
dauer left a comment There was a problem hiding this comment.
Looks correct to me!
A test would have been nice, especially for the ProfileUtil
jdaugherty approved these changes Aug 26, 2025
Contributor Author
# Conflicts: # grails-shell-cli/src/main/groovy/org/grails/cli/profile/commands/io/GradleDependency.groovy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Enhanced ProfileUtil and GradleDependency to support Gradle dependency variants (e.g., platform() or testFixtures()) in profile definitions. Updated profile.yml files to move variant and devtools dependencies from build.gradle into the profile metadata, and added integration test dependency to the web profile. This change improves consistency and flexibility in dependency management for Grails profiles.