Use developmentOnly Gradle configuration scope for webjars #14811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Gradle dependency configurations across various modules to use the developmentOnly scope for webjar dependencies, ensuring they are only included in the development environment.
- Replace "implementation" with "developmentOnly" for 'org.webjars.npm:jquery' in multiple build.gradle files
- Similarly update usage for 'org.webjars.npm:bootstrap' where applicable
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| grails-test-examples/namespaces/build.gradle | Update jQuery dependency configuration |
| grails-test-examples/mongodb/hibernate5/build.gradle | Update jQuery dependency configuration |
| grails-test-examples/mongodb/gson-templates/build.gradle | Update jQuery dependency configuration |
| grails-test-examples/mongodb/database-per-tenant/build.gradle | Update jQuery dependency configuration |
| grails-test-examples/mongodb/base/build.gradle | Update jQuery dependency configuration |
| grails-test-examples/micronaut/build.gradle | Update Bootstrap and jQuery dependency configurations |
| grails-test-examples/issue-11102/build.gradle | Update Bootstrap and jQuery dependency configurations |
| grails-test-examples/hyphenated/build.gradle | Update jQuery dependency configuration |
| grails-test-examples/hibernate5/issue450/build.gradle | Update Bootstrap and jQuery dependency configurations |
| grails-test-examples/hibernate5/grails-schema-per-tenant/build.gradle | Update jQuery dependency configuration |
| grails-test-examples/hibernate5/grails-partitioned-multi-tenancy/build.gradle | Update jQuery dependency configuration |
| grails-test-examples/hibernate5/grails-hibernate/build.gradle | Update jQuery dependency configuration |
| grails-test-examples/hibernate5/grails-database-per-tenant/build.gradle | Update jQuery dependency configuration |
| grails-test-examples/gsp-sitemesh3/build.gradle | Update Bootstrap and jQuery dependency configurations |
| grails-test-examples/geb/build.gradle | Update Bootstrap and jQuery dependency configurations |
| grails-test-examples/demo33/build.gradle | Update Bootstrap and jQuery dependency configurations |
| grails-test-examples/app2/build.gradle | Update jQuery dependency configuration |
| grails-test-examples/app1/build.gradle | Update jQuery dependency configuration |
| grails-data-neo4j/examples/grails3-neo4j/build.gradle | Update jQuery dependency configuration |
| grails-data-neo4j/examples/grails3-neo4j-hibernate/build.gradle | Update jQuery dependency configuration |
Contributor
| @jamesfredley I'd like to understand the reasoning behind this update — could you provide some context? |
Contributor
| We want our functional tests matching how our app generators are generating grails apps. |
Contributor
| @jdaugherty OK, that makes sense, but with |
Contributor
| @matrei wouldn't this be a problem for end apps too then? How would they load assets and test them? |
Contributor
Yes, I believe so. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.