Unnest the snapshot zip uploaded to workflow results #14808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Unnests the snapshot zip uploaded to workflow results by updating the artifact upload path
- Switched the upload-artifact
pathfrom the nested ZIP undergrails-wrapper/build/distributionsto a flattmp/wrapperdirectory
Comments suppressed due to low confidence (1)
.github/workflows/gradle.yml:269
- The upload-artifact path was changed to
tmp/wrapper, but there’s no preceding step that creates or unpacks files into this directory, so the artifact upload may end up empty. Consider adding a step to unzip the snapshot intotmp/wrapperor revert to uploading the ZIP directly with a proper glob pattern.
path: tmp/wrapper 
matrei approved these changes Jun 12, 2025
jdaugherty approved these changes Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This does not run the publish steps until the PR is merged.
Example with nesting: https://github.com/apache/grails-core/actions/runs/15598307628/artifacts/3311305695