Merge pull request #14921 from apache/spring-dev-tools-default

Set spring boot dev tools as a default feature in forge to match profiles

Author: jamesfredley

grails-forge/grails-forge-core/src/main/java/org/grails/forge/build/gradle/GradleDependency.java

@@ -116,6 +116,10 @@ public String toSnippet() {
  if (isPom() || gradleConfiguration == INTEGRATION_TEST_IMPLEMENTATION_TEST_FIXTURES) {
  snippet += ")";
  }
+ if (getArtifactId() == "spring-boot-devtools") {
+ snippet += " // Spring Boot DevTools may cause performance slowdowns or compatibility issues on larger applications";
+ }
+
  return snippet;
  }
 }

grails-forge/grails-forge-core/src/main/java/org/grails/forge/feature/reloading/SpringBootDevTools.java

@@ -19,13 +19,18 @@
 package org.grails.forge.feature.reloading;
 
 import jakarta.inject.Singleton;
+import org.grails.forge.application.ApplicationType;
 import org.grails.forge.application.generator.GeneratorContext;
 import org.grails.forge.build.dependencies.Dependency;
 import org.grails.forge.build.dependencies.Scope;
+import org.grails.forge.feature.DefaultFeature;
+import org.grails.forge.feature.Feature;
+import org.grails.forge.options.Options;
 
+import java.util.Set;
 
 @Singleton
-public class SpringBootDevTools implements ReloadingFeature {
+public class SpringBootDevTools implements ReloadingFeature, DefaultFeature {
  @Override
  public String getName() {
  return "spring-boot-devtools";
@@ -54,8 +59,18 @@ public boolean isVisible() {
  return true;
  }
 
+ @Override
+ public boolean shouldApply(ApplicationType applicationType, Options options, Set<Feature> selectedFeatures) {
+ return true;
+ }
+
+ @Override
+ public boolean supports(ApplicationType applicationType) {
+ return true;
+ }
+
  @Override
  public String getDocumentation() {
- return "https://docs.spring.io/spring-boot/docs/2.7.12/reference/htmlsingle/#using.devtools";
+ return "https://docs.spring.io/spring-boot/reference/using/devtools.html";
  }
 }

grails-gradle/plugins/src/main/groovy/org/grails/gradle/plugin/core/GrailsGradlePlugin.groovy

@@ -846,6 +846,11 @@ class GrailsGradlePlugin extends GroovyPlugin {
  SourceSet mainSourceSet = SourceSets.findMainSourceSet(project)
  it.classpath = mainSourceSet.runtimeClasspath + project.configurations.getByName('console')
  it.systemProperty(Environment.KEY, System.getProperty(Environment.KEY, Environment.DEVELOPMENT.getName()))
+
+ // devtools' automatic restart mechanism uses a specialized classloader setup, which can interfere
+ // with Grails' plugin management and bean wiring when running CLI scripts via Gradle
+ it.systemProperty 'spring.devtools.restart.enabled', 'false'
+
  List<Object> args = []
  def otherArgs = project.findProperty('args')
  if (otherArgs) {
@@ -873,6 +878,10 @@ class GrailsGradlePlugin extends GroovyPlugin {
  it.classpath = mainSourceSet.runtimeClasspath + project.configurations.getByName('console')
  it.systemProperty(Environment.KEY, System.getProperty(Environment.KEY, Environment.DEVELOPMENT.getName()))
 
+ // devtools' automatic restart mechanism uses a specialized classloader setup, which can interfere
+ // with Grails' plugin management and bean wiring when running CLI commands via Gradle
+ it.systemProperty 'spring.devtools.restart.enabled', 'false'
+
  List<Object> args = []
  def otherArgs = project.findProperty('args')
  if (otherArgs) {