Add tests with external DTD

Add tests for `XmlStringLookup` with an external DTD.

Author: ppkarwasz

src/test/java/org/apache/commons/text/lookup/XmlStringLookupTest.java

@@ -76,6 +76,21 @@ void testExternalEntityOn() {
  assertEquals(DATA, new XmlStringLookup(EMPTY_MAP, XmlStringLookup.DEFAULT_XPATH_FEATURES).apply(key).trim());
  }
 
+ @Test
+ void testInterpolatorExternalDtdOff() {
+ final StringSubstitutor stringSubstitutor = StringSubstitutor.createInterpolator();
+ assertThrows(IllegalArgumentException.class, () -> stringSubstitutor.replace("${xml:" + DOC_DIR
+ + "document-external-dtd.xml:/document/content}"));
+ }
+
+ @Test
+ @SetSystemProperty(key = "XmlStringLookup.secure", value = "false")
+ void testInterpolatorExternalDtdOn() {
+ final StringSubstitutor stringSubstitutor = StringSubstitutor.createInterpolator();
+ assertEquals("This is an external entity.",
+ stringSubstitutor.replace("${xml:" + DOC_DIR + "document-external-dtd.xml:/document/content}").trim());
+ }
+
  @Test
  void testInterpolatorExternalEntityOff() {
  final StringSubstitutor stringSubstitutor = StringSubstitutor.createInterpolator();

src/test/resources/org/apache/commons/text/document-external-dtd.dtd

@@ -0,0 +1,20 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ https://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<!ENTITY externalEntity "This is an external entity.">
+<!ELEMENT document (title, content)>
+<!ELEMENT title (#PCDATA)>
+<!ELEMENT content (#PCDATA)>

src/test/resources/org/apache/commons/text/document-external-dtd.xml

@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ https://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+ -->
+<!DOCTYPE document SYSTEM "src/test/resources/org/apache/commons/text/document-external-dtd.dtd">
+<document>
+ <title>Example of an External Entity</title>
+ <content>
+ &externalEntity;
+ </content>
+</document>