Skip to content

Commit 736ed57

Browse files
committed
Update WebView tracker version WebView plugin to fix issue with tracking page view and page ping event properties
1 parent e9316f0 commit 736ed57

File tree

5 files changed

+23
-22
lines changed

5 files changed

+23
-22
lines changed

common/config/rush/pnpm-lock.yaml

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

common/config/rush/repo-state.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// DO NOT MODIFY THIS FILE MANUALLY BUT DO COMMIT IT. It is generated and used by Rush.
22
{
3-
"pnpmShrinkwrapHash": "bf29537a7fb7a501d796ce47e6bdb37daa9b0507",
3+
"pnpmShrinkwrapHash": "6f4a24fea0d73ed30b10703fd10b02f67710f7ba",
44
"preferredVersionsHash": "bf21a9e8fbc5a3846fb05b4fa0859e0917b2202f"
55
}

plugins/browser-plugin-webview/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"@snowplow/browser-tracker-core": "workspace:*",
2626
"@snowplow/tracker-core": "workspace:*",
2727
"tslib": "^2.3.1",
28-
"@snowplow/webview-tracker": "^0.3.0"
28+
"@snowplow/webview-tracker": "^0.3.1"
2929
},
3030
"devDependencies": {
3131
"@ampproject/rollup-plugin-closure-compiler": "~0.27.0",

plugins/browser-plugin-webview/src/index.ts

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { BrowserPlugin, Payload } from '@snowplow/browser-tracker-core';
22
import { hasMobileInterface, trackWebViewEvent } from '@snowplow/webview-tracker';
33
import { Logger, SelfDescribingEvent, SelfDescribingJson } from '@snowplow/tracker-core';
44
import { base64urldecode } from './utils';
5+
import { AtomicProperties } from '@snowplow/webview-tracker/dist/api';
56

67
type WebViewPluginOptions = {
78
/**
@@ -27,22 +28,22 @@ export function WebViewPlugin(configuration?: WebViewPluginOptions): BrowserPlug
2728
if (hasMobileInterface() === true) {
2829
LOG.debug(`Payload (event ID: ${payload.eid}) was filtered out and forwarded to WebView tracker.`);
2930

30-
let atomicProperties = {
31+
let atomicProperties: AtomicProperties = {
3132
eventName: payload.e as string,
3233
trackerVersion: payload.tv as string,
3334
useragent: (payload.ua as string) ?? window.navigator.userAgent,
34-
url: payload.url as string | undefined,
35-
title: payload.page as string | undefined,
35+
pageUrl: payload.url as string | undefined,
36+
pageTitle: payload.page as string | undefined,
3637
referrer: payload.refr as string | undefined,
3738
category: payload.se_ca as string | undefined,
3839
action: payload.se_ac as string | undefined,
3940
label: payload.se_la as string | undefined,
4041
property: payload.se_pr as string | undefined,
4142
value: payload.se_va !== undefined ? parseFloat(payload.se_va as string) : undefined,
42-
minXOffset: payload.pp_mix !== undefined ? parseInt(payload.pp_mix as string) : undefined,
43-
maxXOffset: payload.pp_max !== undefined ? parseInt(payload.pp_max as string) : undefined,
44-
minYOffset: payload.pp_miy !== undefined ? parseInt(payload.pp_miy as string) : undefined,
45-
maxYOffset: payload.pp_may !== undefined ? parseInt(payload.pp_may as string) : undefined,
43+
pingXOffsetMin: payload.pp_mix !== undefined ? parseInt(payload.pp_mix as string) : undefined,
44+
pingXOffsetMax: payload.pp_max !== undefined ? parseInt(payload.pp_max as string) : undefined,
45+
pingYOffsetMin: payload.pp_miy !== undefined ? parseInt(payload.pp_miy as string) : undefined,
46+
pingYOffsetMax: payload.pp_may !== undefined ? parseInt(payload.pp_may as string) : undefined,
4647
};
4748
let event = getSelfDescribingEventData(payload);
4849
let entities = getEntities(payload);

plugins/browser-plugin-webview/test/webview.test.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ describe('WebView plugin', () => {
7676
eventName: 'pv',
7777
trackerVersion: 'js-4.0.0',
7878
useragent: expect.any(String),
79-
url: expect.any(String),
79+
pageUrl: expect.any(String),
8080
},
8181
context: [
8282
{
@@ -94,18 +94,18 @@ describe('WebView plugin', () => {
9494
eventName: 'ue',
9595
trackerVersion: 'js-4.0.0',
9696
useragent: expect.any(String),
97-
url: expect.any(String),
98-
title: undefined,
97+
pageUrl: expect.any(String),
98+
pageTitle: undefined,
9999
referrer: undefined,
100100
category: undefined,
101101
action: undefined,
102102
label: undefined,
103103
property: undefined,
104104
value: undefined,
105-
minXOffset: undefined,
106-
maxXOffset: undefined,
107-
minYOffset: undefined,
108-
maxYOffset: undefined,
105+
pingXOffsetMin: undefined,
106+
pingXOffsetMax: undefined,
107+
pingYOffsetMin: undefined,
108+
pingYOffsetMax: undefined,
109109
},
110110
event: {
111111
schema: 'iglu:com.snowplowanalytics.snowplow.media/play_event/jsonschema/1-0-0',
@@ -164,7 +164,7 @@ describe('WebView plugin', () => {
164164
eventName: 'ue',
165165
trackerVersion: 'js-4.0.0',
166166
useragent: expect.any(String),
167-
url: expect.any(String),
167+
pageUrl: expect.any(String),
168168
},
169169
event: {
170170
schema: 'iglu:com.snowplowanalytics.snowplow/example/jsonschema/1-0-0',

0 commit comments

Comments
 (0)