fix(terraform_docs): apply some of yermulnik suggestions

Author: tarfu

hooks/terraform_docs.sh

@@ -1,5 +1,6 @@
 #!/usr/bin/env bash
 set -eo pipefail
+
 # globals variables
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd -P)"
 readonly SCRIPT_DIR
@@ -143,15 +144,17 @@ function terraform_docs {
 
  else
  have_config_flag=true
- local config_file=${args#*--config}
- config_file=${config_file#*=}
- # If there are more parameters after config path, trim until --
- if [[ $config_file == *" --"* ]]; then
- config_file=${config_file%% --*}
- fi
- # Trim trailing whitespace but preserve internal spaces
-
- config_file="${config_file%"${config_file##*[![:space:]]}"}" args=${args/--config=$config_file/}
+ # Enable extended pattern matching operators
+ shopt -qp extglob || EXTGLOB_IS_NOT_SET=true && shopt -s extglob
+ # Trim any args before the `--config` arg value
+ local config_file=${args##*--config@(+([[:space:]])|=)}
+ # Trim any trailing spaces and args (if any)
+ config_file="${config_file%%+([[:space:]])?(--*)}"
+ # Trim `--config` arg and its value from original args as we will
+ # pass `--config` separately to allow whitespaces in its value
+ args=${args/--config@(+([[:space:]])|=)$config_file*([[:space:]])/}
+ # Restore state of `extglob` if we changed it
+ [[ $EXTGLOB_IS_NOT_SET ]] && shopt -u extglob
 
  # Prioritize `.terraform-docs.yml` `output.file` over
  # `--hook-config=--path-to-file=` if it set
@@ -237,10 +240,8 @@ function terraform_docs {
  have_marker=$(grep -o "$insertion_marker_begin" "$output_file") || unset have_marker
  [[ ! $have_marker ]] && popd > /dev/null && continue
  fi
- local config_options=""
- if [[ $have_config_flag == true ]]; then
- config_options="--config=$config_file"
- fi
+ local config_options
+ [[ $have_config_flag == true ]] && config_options="--config=$config_file"
  # shellcheck disable=SC2086
  terraform-docs --output-mode="$output_mode" --output-file="$output_file" $tf_docs_formatter "$config_options" $args ./ > /dev/null