This repository was archived by the owner on Apr 4, 2025. It is now read-only.
Build optimizer #27
Merged
Build optimizer #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
hansl suggested changes Jul 11, 2017
| return pkg; | ||
| } | ||
| | ||
| |
Contributor
There was a problem hiding this comment.
nit: double spaces between top-level declarations.
| @@ -0,0 +1,27 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
Replace - with _ in folder names.
| "lite-server": "^2.3.0", | ||
| "ngo-loader": "alxhub/ngo", | ||
| "protractor": "^5.1.2", | ||
| "purify": "igorminar/purify", |
Contributor Author
There was a problem hiding this comment.
Purify and ngo-loader are needed for the parity test, otherwise I can't test if build-optimizer is performing at least as well.
| ) { } | ||
| | ||
| ngOnInit() { | ||
| // Do not initialize the search on browsers that lack web worker support |
Contributor
There was a problem hiding this comment.
Is that code supposed to be in comments? If so, please add a comment explaining that this comment is for a specific test.
| @@ -0,0 +1,6 @@ | |||
| export interface DocumentContents { | |||
Contributor
There was a problem hiding this comment.
Underscore in the directory names.
hansl approved these changes Jul 11, 2017
| import { getScrubFileTransformer } from '../transforms/scrub-file'; | ||
| | ||
| | ||
| const HAS_DECORATORS = /decorators/; |
Contributor
There was a problem hiding this comment.
We don't do all-caps on const.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.