Skip to content

@angular/fire and its use of PendingTasks.run causes promise rejections to be handled twice #61932

Closed
angular/angularfire
#3657
@LanderBeeuwsaert

Description

@LanderBeeuwsaert

Which @angular/* package(s) are the source of the bug?

core

Is this a regression?

Yes

Description

this is a continuance on the ticket I created yesterday:
#61904

Here you can find what happens with angular v20:
https://stackblitz.com/edit/wnadcef6?file=src%2Fapp%2Fapp.ts

Here you can find what happens with angular v19:
https://stackblitz.com/edit/wnadcef6-taqdi3xq?file=package.json,src%2Fmain.ts,src%2Fapp%2Fapp.ts

From the comments in the previous ticket and the angular changelog, I can understand that this change was maybe intentional.
However, in my opinion it creates a reduction in developer experience.

if I catch an error locally because I know in this situation I expect sometimes certain errors to happen and want to ignore or treat them locally (showing a nice message to our users), I don't want these errors to also be forwarded to the global custom error handler. Because there we have global logging about how many actual real issues we have in the application. But errors I treat locally are not real issues.

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

 

Please provide the environment you discovered this bug in (run ng version)

 

Anything else?

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions